Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile skeleton.Rmd files #204

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Reconcile skeleton.Rmd files #204

merged 4 commits into from
Jul 25, 2024

Conversation

kelliemac
Copy link
Contributor

@kelliemac kelliemac commented Jul 24, 2024 •
edited
Loading

Description

I noticed that there were some inconsistencies between the visc_empty and visc_report skeleton.Rmd files. I attempted to resolve those and also to keep the visc_empty skeleton.Rmd as minimal as possible.

Question for reviewers:

  1. Does the visc_empty skeleton.Rmd contain all of the basic elements?
  2. Is there anything in the visc_empty skeleton.Rmd that could be simplified further?
  3. Are the changes to visc_report skeleton.Rmd acceptable?

Related Issues

Related to #203

Checklist

  • This PR includes unit tests
  • This PR establishes a new function or updates parameters in an existing function
    • The roxygen skeleton for this function has been updated using devtools::document
  • I have updated NEWS.md to describe the proposed changes

@kelliemac kelliemac requested review from slager and mayerbry July 24, 2024 16:56
mayerbry
mayerbry approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@mayerbry mayerbry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with updates, thanks for tidying these up!

@kelliemac kelliemac merged commit 23b263a into develop Jul 25, 2024
6 checks passed
@kelliemac kelliemac deleted the reconcile-visc_empty-and-visc_report branch July 25, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayerbry mayerbry mayerbry approved these changes

@slager slager Awaiting requested review from slager

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelliemac @mayerbry