Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authors in DESCRIPTION #190

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Update authors in DESCRIPTION #190

merged 3 commits into from
Jul 18, 2024

Conversation

kelliemac
Copy link
Contributor

Addresses #180

@slager I have listed you as the current maintainer since you have been the most active recently in fixing bugs (thank you!!!) Let me know if you don't want to do this though - we can easily switch it to me or Bryan.

If anyone has other ideas of people who should be includes in the authors list, as either full authors or contributors, just say so. For reference here is a guide to how the author roles work: https://r-pkgs.org/description.html#sec-description-authors-at-r

@slager
Copy link
Contributor

slager commented Jul 15, 2024

I'd be happy to keep regularly contributing as an author on bugfixes/etc, but I'm less comfortable being the official maintainer. I feel like it could be good to keep it officially maintained by someone who's main work/expertise is closer to the PT report workflow.

@kelliemac
Copy link
Contributor Author

Ok! Totally get that @slager. We can have multiple maintainers, too. What if I give Bryan, me, and you all the "cre" designation, just to denote that we're the ones who are actively working on it in any capacity?

@slager
Copy link
Contributor

slager commented Jul 15, 2024

That setup sounds fine to me. It's possible that R CMD check might complain about multiple maintainers.

The mandatory ‘Maintainer’ field should give a single name followed by a valid (RFC 2822) email address in angle brackets

@kelliemac
Copy link
Contributor Author

ok, in that case I'll just put myself as the maintainer for now since I don't mind being the person who people reach out to

@kelliemac
Copy link
Contributor Author

@mayerbry ok by you?

Copy link
Contributor

@mayerbry mayerbry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, thanks Kellie!

@kelliemac kelliemac merged commit 783e960 into develop Jul 18, 2024
6 checks passed
@slager slager deleted the update-authors branch July 23, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants