Skip to content

Add ectool support for framework laptop #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

razzius
Copy link

@razzius razzius commented Mar 3, 2022

Without this patch:

EmbeddedController $ make utils
  VERSION ec_version.h
  HOSTCC  util/ectool
  HOSTCC  util/lbplay
  HOSTCC  util/stm32mon
  HOSTCC  util/ec_sb_firmware_update
  HOSTCC  util/lbcc
  HOSTCC  util/ec_parse_panicinfo
  HOSTCC  util/cbi-util
  HOSTCC  util/uartupdatetool
EmbeddedController $ sudo ./build/bds/util/ectool led power red
Missing Chromium EC memory map.
Cannot find I2C adapter
Unable to establish host communication
Couldn't find EC

With this patch:

EmbeddedController $ make utils
  VERSION ec_version.h
  HOSTCC  util/ectool
  HOSTCC  util/lbplay
  HOSTCC  util/stm32mon
  HOSTCC  util/ec_sb_firmware_update
  HOSTCC  util/lbcc
  HOSTCC  util/ec_parse_panicinfo
  HOSTCC  util/cbi-util
  HOSTCC  util/uartupdatetool
EmbeddedController $ sudo ./build/bds/util/ectool led power red
EmbeddedController $

And the light changes.

This also fixes an issue where if you run ectool without sudo permission, it errors, leaving behind the lockfile; I had to add the release_gec_lock() in 2 places, so maybe there's a better way to do this.

The ectool support is all taken from https://github.com/DHowett/fw-ectool, which was published before this repository. I opened an issue with the lock file there: DHowett#1.

I have no idea if y'all are interested in this or if I'm going about it the right way :)

@razzius
Copy link
Author

razzius commented Mar 3, 2022

I opened this before seeing #5 ! Both of these PRs make the ectool work with the framework laptop.

@DHowett
Copy link
Contributor

DHowett commented Mar 9, 2022

@razzius FYI the code in fw-ectool is a bit outdated compared to #5 😄

I should merge it back, of course, but I've been a bit busy with life things.

(Thanks!)

@DHowett
Copy link
Contributor

DHowett commented Apr 12, 2022

FYI: I've replaced the original (fairly hacky :P) code in fw-ectool with the version I was trying to upstream in #5. It no longer requires --comm=fwk, as it's now another personality for the lpc driver.

@DHowett
Copy link
Contributor

DHowett commented Jan 5, 2023

Since #5 merged, this PR has become obsolete -- but thanks for bringing it in @razzius 😄

@razzius
Copy link
Author

razzius commented Jan 6, 2023

Thanks for circling back around @DHowett and for offering your patches!

@razzius razzius closed this Jan 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants