add changes from pull request

Fourteen98 · Jul 30, 2022 · 29f3861 · 29f3861
1 parent 711b924
commit 29f3861
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 33 deletions.
diff --git a/MIT.md b/MIT.md
@@ -1,10 +1,7 @@
-## Copyright 2021, [YOUR NAME]
+## Copyright 2021, Alejandro Torres && Muhyideen Elias 
 
-###### Please delete this line and the next one
-###### APP TYPE can be a webpage/website, a web app, a software and so on
+Permission is hereby granted, free of charge, to any person obtaining a copy of this webpage and associated documentation files, to deal in the webpage without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the webpage, and to permit persons to whom the webpage is furnished to do so, subject to the following conditions:
 
-Permission is hereby granted, free of charge, to any person obtaining a copy of this [APP TYPE] and associated documentation files, to deal in the [APP TYPE] without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the [APP TYPE], and to permit persons to whom the [APP TYPE] is furnished to do so, subject to the following conditions:
+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the webpage.
 
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the [APP TYPE].
-
-THE [APP TYPE] IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE [APP TYPE] OR THE USE OR OTHER DEALINGS IN THE [APP TYPE].
+THE WEBPAGE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE WEBPAGE OR THE USE OR OTHER DEALINGS IN THE WEBPAGE.
diff --git a/README.md b/README.md
@@ -42,6 +42,10 @@ clone the repo or download from https://github.com/Fourteen98/Pokemone.git
 
 `npm start `
 This automatically start app on localhost:3000
+### test the app
+
+`npm test `
+This automatically test the app for certain situations
 
 ### Deployment
 

diff --git a/dist/index.bundle.js b/dist/index.bundle.js
diff --git a/dist/index.html b/dist/index.html
@@ -24,7 +24,7 @@
           integrity="sha512-KfkfwYDsLkIlwQp6LFnl8zNdLGxu9YAA1QvwINks4PhcElQSvqcyVLLD9aMhXd13uQjoXtEKNosOWaZqXgel0g=="
           crossorigin="anonymous" referrerpolicy="no-referrer"/>
 
-<script defer src="/runtime.bundle.js"></script><script defer src="/index.bundle.js"></script></head>
+<script defer src="runtime.bundle.js"></script><script defer src="index.bundle.js"></script></head>
 <body>
 <div class="main">
     <header>

diff --git a/server.js b/server.js
@@ -15,8 +15,3 @@ app.use(
     publicPath: config.output.publicPath,
   }),
 );
-
-// Serve the files on port 3000.
-// app.listen(3000, () => {
-//   console.log('Example app listening on port 3000!\n');
-// });
diff --git a/src/modules/create-card.js b/src/modules/create-card.js
@@ -75,20 +75,13 @@ const creatCard = (pokemon) => {
 
   row.appendChild(col);
 
-  setTimeout(() => involvementFetchLikes(pokemon.id.toString(), likeCount)
-    .catch((error) => {
-      console.log(error);
-    }), 1000);
+  setTimeout(() => involvementFetchLikes(pokemon.id.toString(), likeCount), 1000);
 
   iTag.addEventListener('click', (e) => {
     const likes = parseInt(likeCount.innerText.split(' ')[0]);
     likeCount.innerText = `${likes + 1} likes`;
     involvementPostLikes(e, likeCount.innerText.split(' ')[0])
-      .then((r) => console.log(r))
-      .catch((err) => console.log(err));
     involvementFetchLikes(e.target.id, likeCount)
-      .then((r) => console.log(r))
-      .catch((err) => console.log(err));
   });
 };
 

diff --git a/webpack.config.js b/webpack.config.js
@@ -19,7 +19,6 @@ module.exports = {
     filename: '[name].bundle.js',
     path: path.resolve(__dirname, 'dist'),
     clean: true,
-    publicPath: '/',
   },
   optimization: {
     runtimeChunk: 'single',