Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthRepository의 existsInitInfo 타입을 Result나 다른 타입으로 수정하기 #23

Closed
jja08111 opened this issue Jan 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jja08111
Copy link
Contributor

이 기능으로 해결하는 문제

아래의 코드를 보면 주석이 없이는 설명하기 어떤 값이 어떤 의미를 담는지 이해하기 어렵다. 이를 개선해야한다.

/**
* `currentUserIdStream`이 `true`인데 이 값이 `null`인 경우 서버와의 연결을 실패한 경우이다.
*/
val existsInitInfo: Boolean?

내가 생각한 솔루션

existsInitInfo 타입을 Result나 다른 타입으로 수정하거나 아니면 아예 구조를 바꾸기

@jja08111 jja08111 added the enhancement New feature or request label Jan 25, 2024
jja08111 added a commit that referenced this issue Jan 29, 2024
jja08111 added a commit that referenced this issue Jan 29, 2024
jja08111 added a commit that referenced this issue Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant