fix(gotjunk): Fix classification bypass + double-capture race condition

[Foundup]

Summary

Fixes two critical UX bugs:

1. Classification modal bypass - Quick tap on Discount/Bid bypassed options menu
2. Double-picture capture - Touch+mouse events fired simultaneously, creating duplicates

Problem 1: Classification Modal Quick-Tap Bypass

Before:

• User takes picture → Tap "Discount" → Modal closes instantly with 75% default ❌
• User perception: "The choice was bypassed!"

After:

• User takes picture → Tap "Discount" → Action sheet opens → User selects 25%/50%/75% ✓
• Predictable, no surprises

Root Cause:

// BEFORE (ClassificationModal.tsx:52)
onTap: () => onClassify('discount', discountPercent)  // ❌ Instant save

// AFTER
onTap: () => setDiscountSheetOpen(true)  // ✓ Always show options

Problem 2: Double-Picture Capture

Before:

• User taps camera → Two identical pictures appear (Bid 48h, $25) ❌
• Screenshot evidence: Two identical glass cups with same badge

After:

• User taps camera → ONE picture captured ✓
• Capture lock prevents race condition

Root Cause:

// Camera button had BOTH event types
<div
  onMouseDown={handlePressStart}   // Desktop
  onMouseUp={handlePressEnd}       // Desktop
  onTouchStart={handlePressStart}  // Mobile
  onTouchEnd={handlePressEnd}      // Mobile - BOTH fire on iPhone!
>

On mobile browsers, both touch AND mouse events fire → takePhoto() called twice.

Fix:

// Added capture lock (BottomNavBar.tsx:46)
const captureLockRef = useRef<boolean>(false);

// Lock mechanism (lines 107-124)
if (captureLockRef.current) {
  console.log('[GotJunk] Capture blocked - lock active');
  return;  // Prevent duplicate
}

captureLockRef.current = true;
cameraRef.current?.takePhoto();  // Only fires once

setTimeout(() => {
  captureLockRef.current = false;  // Release after 500ms
}, 500);

Changes

ClassificationModal.tsx:

• Line 52: Discount onTap → always open sheet
• Line 63: Bid onTap → always open sheet

BottomNavBar.tsx:

• Line 46: Added captureLockRef
• Lines 107-124: Capture lock with 500ms cooldown

HOLO_INDEX_IMPROVEMENT_LOG.md:

• Documented HoloIndex empty preview issue
• Actionable recommendations for another 0102 to fix

Investigation Method

1. Used HoloIndex (agentic search) to identify relevant files
2. Created improvement log when HoloIndex returned empty previews
3. Surgical code reading to find exact root cause
4. Applied Occam's Razor - simplest lock mechanism (useRef, not state)

Test Plan

• Take picture → Tap Discount → Verify action sheet opens (not bypass)
• Take picture → Tap Bid → Verify action sheet opens (not bypass)
• Select 50% discount → Verify saves correctly
• Rapid tap camera → Verify only ONE picture captured
• Check console logs: [GotJunk] Capture blocked on duplicate attempts

Build Output

✓ 424 modules transformed
✓ built in 2.52s
dist/index.html                   1.53 kB │ gzip:   0.70 kB
dist/assets/index-BK78dVSP.css    0.32 kB │ gzip:   0.22 kB
dist/assets/index-Dan9UgKC.js   418.27 kB │ gzip: 131.16 kB

WSP Compliance

• ✓ WSP_00: Zen State Protocol (surgical fixes, no vibecoding)
• ✓ WSP_50: Pre-action verification (HoloIndex search first)
• ✓ First Principles: Occam's Razor (minimal lock mechanism)

🤖 Generated with Claude Code