Remove more non ASCII stuff (#113)

FoundryAI · Jun 28, 2019 · ea99691 · ea99691
1 parent 1066d4b
commit ea99691
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 20 deletions.
diff --git a/kedro/config/config.py b/kedro/config/config.py
@@ -70,22 +70,22 @@ class ConfigLoader:
         ::
 
             .
-            └── conf
-                ├── README.md
-                ├── base
-                │   ├── catalog.yml
-                │   ├── logging.yml
-                │   └── experiment1
-                │       └── parameters.yml
-                └── local
-                    ├── catalog.yml
-                    ├── db.ini
-                    ├── experiment1
-                    │   ├── parameters.yml
-                    │   └── model_parameters.yml
-                    └── experiment2
-                        └── parameters.yml
-               
+            `-- conf
+                |-- README.md
+                |-- base
+                |   |-- catalog.yml
+                |   |-- logging.yml
+                |   `-- experiment1
+                |       `-- parameters.yml
+                `-- local
+                    |-- catalog.yml
+                    |-- db.ini
+                    |-- experiment1
+                    |   |-- parameters.yml
+                    |   `-- model_parameters.yml
+                    `-- experiment2
+                        `-- parameters.yml
+
 
         You can access the different configurations as follows:
         ::

diff --git a/setup.py b/setup.py
@@ -82,7 +82,7 @@
     author="QuantumBlack Labs",
     entry_points={"console_scripts": ["kedro = kedro.cli:main"]},
     package_data={name: template_files + doc_html_files},
-    keywords="pipelines, machine learning, data pipelines, data science, data engineering",
+    keywords="pipelines, machine learning, data pipelines, data science, data engineering",
     classifiers=[
         "Development Status :: 4 - Beta",
         "Programming Language :: Python :: 3.5",

diff --git a/tests/cli/conftest.py b/tests/cli/conftest.py
@@ -28,7 +28,7 @@
 
 """
 This file contains the fixtures that are reusable by any tests within
-this directory. You don’t need to import the fixtures as pytest will
+this directory. You don't need to import the fixtures as pytest will
 discover them automatically. More info here:
 https://docs.pytest.org/en/latest/fixture.html
 """

diff --git a/tests/conftest.py b/tests/conftest.py
@@ -28,7 +28,7 @@
 
 """
 This file contains the fixtures that are reusable by any tests within
-this directory. You don’t need to import the fixtures as pytest will
+this directory. You don't need to import the fixtures as pytest will
 discover them automatically. More info here:
 https://docs.pytest.org/en/latest/fixture.html
 """

diff --git a/tests/io/conftest.py b/tests/io/conftest.py
@@ -28,7 +28,7 @@
 
 """
 This file contains the fixtures that are reusable by any tests within
-this directory. You don’t need to import the fixtures as pytest will
+this directory. You don't need to import the fixtures as pytest will
 discover them automatically. More info here:
 https://docs.pytest.org/en/latest/fixture.html
 """

diff --git a/tools/license_and_headers.py b/tools/license_and_headers.py
@@ -27,6 +27,7 @@
 # limitations under the License.
 
 import glob
+import sys
 
 PATHS_REQUIRING_HEADER = ["kedro", "tests"]
 LEGAL_HEADER_FILE = "legal_header.txt"
@@ -77,6 +78,17 @@ def files_missing_substring(file_names, substring):
             if content.strip() and substring not in content:
                 yield file_name
 
+            # In some locales Python 3.5 on Windows can't deal with non ascii chars in source files
+            try:
+                content.encode("ascii")
+            except UnicodeError as e:
+                print(
+                    "Non ascii characters in {} after '{}'".format(
+                        file_name, content[e.start - 30 : e.start]
+                    )
+                )
+                yield file_name
+
 
 def main():
     exit_code = 0