Handle empty IMAP parts from Outlook.com servers #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick fix from upstream mailcore2 PR #1621. Outlook.com IMAP server sometimes omits message parts and returns them as zero-length when there is a vCalendar part in the message. Previously this would cause a MAILIMAP_ERROR_FETCH error, failing the entire fetch. This fix: 1. Adds mOutlookServer detection based on hostname 2. When fetching from Outlook and encountering a NULL/empty part, returns zero-length data instead of an error This allows messages with vCalendar attachments to be fetched successfully from Outlook.com accounts. Upstream: MailCore/mailcore2#1621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick fix from upstream mailcore2 PR #1621.
Outlook.com IMAP server sometimes omits message parts and returns them as zero-length when there is a vCalendar part in the message. Previously this would cause a MAILIMAP_ERROR_FETCH error, failing the entire fetch.
This fix:
This allows messages with vCalendar attachments to be fetched successfully from Outlook.com accounts.
Upstream: MailCore/mailcore2#1621