Improve the check for Pod spec changes

[johscheuer]

Description

In the current implementation we could hit issues if someone changes the pods outside the operator control, e.g. by manually changing the pod spec with kubectl edit ... The risk is fairly minimal since the pod spec has a limited set of fields that can be changed, but in general the operator should validate those fields, e.g. in case someone changes the image of a running pod.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Discussion

I discussed this offline and we probably want to add a new annotation to the operator which can be set on a per pod level to ignore pod changes. This could be useful in debugging cases where a user wants to keep the pod running, but wants to pull a container with additional debugging tooling. I create a GitHub issue for this before merging.

Testing

Added additional unit and e2e tests.

Documentation

Follow-up

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

• Commit ID: 68fe5c8
• Duration 4:17:01
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

• Commit ID: 68fe5c8
• Duration 4:17:24
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

• Commit ID: 10229e5
• Duration 2:03:52
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)