Skip to content

Conversation

johscheuer
Copy link
Member

Description

Fixes: #782

Type of change

  • New feature (non-breaking change which adds functionality)

Discussion

I moved the metrics code a bit around for better usability.

Testing

I did a manual test, right now we don't have any specific e2e tests for the metrics:

bash-5.1$ curl -s localhost:8080/metrics | grep coordinator
# HELP fdb_operator_coordinator_changes_total Total number of coordinator changes performed on the cluster
# TYPE fdb_operator_coordinator_changes_total counter
fdb_operator_coordinator_changes_total{name="jdev",namespace="jscheuermann"} 2
bash-5.1$ curl -s localhost:8080/metrics | grep coordinator
# HELP fdb_operator_coordinator_changes_total Total number of coordinator changes performed on the cluster
# TYPE fdb_operator_coordinator_changes_total counter
fdb_operator_coordinator_changes_total{name="jdev",namespace="jscheuermann"} 3

Documentation

Follow-up

@johscheuer johscheuer requested a review from nicmorales9 October 1, 2025 08:17
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 6a8d65f
  • Duration 1:58:17
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does seem nice! LGTM

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: a4ef837
  • Duration 2:44:06
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Oct 2, 2025
@johscheuer johscheuer reopened this Oct 2, 2025
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: a4ef837
  • Duration 1:56:11
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit 3748aa9 into FoundationDB:main Oct 2, 2025
24 of 25 checks passed
@johscheuer johscheuer deleted the add-coordinator-change-metric branch October 2, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a counter for coordinator changes through the operator
3 participants