Skip to content

Conversation

johscheuer
Copy link
Member

Description

Before those changes only one backup and restore worked. Since we are adding more tests we have to improve the test suite for the backup and restore part of the operator.

Type of change

  • Other

Discussion

Testing

Ran the e2e tests.

Documentation

Follow-up

@johscheuer johscheuer marked this pull request as draft September 10, 2025 18:02
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: ece79a6
  • Duration 2:19:06
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 63e653d
  • Duration 2:19:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer marked this pull request as ready for review September 12, 2025 12:51
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: e5e9cf7
  • Duration 2:56:37
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 51c7af4
  • Duration 2:07:00
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Sep 15, 2025
@johscheuer johscheuer reopened this Sep 15, 2025
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 51c7af4
  • Duration 2:45:56
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Sep 15, 2025
@johscheuer johscheuer reopened this Sep 15, 2025
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 51c7af4
  • Duration 2:53:29
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer
Copy link
Member Author

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 51c7af4
  • Duration 2:53:29
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
[Container] 2025/09/15 13:57:16.701721 Running command if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/logs/*.log; export fail_test=true; fi
TESTS FAILED SEE THESE LOGS:

/codebuild/output/src1840832526/src/github.com/FoundationDB/fdb-kubernetes-operator/logs/test_operator_ha_upgrades.log

[Container] 2025/09/15 13:57:17.836583 Running command for f in $(grep -L -- "SUCCESS\!" ${CODEBUILD_SRC_DIR}/logs/*.log); do if ! grep -q -- "--- FAIL:" $f; then echo "This test has timed out or had a panic: $f"; export fail_test=true; fi ;  done

Unrelated failure.

Copy link
Contributor

@akankshamahajan15 akankshamahajan15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these changes with my changes (which is adding additional test - encryption backup test) and it passes successfully.

@johscheuer johscheuer force-pushed the improve-backup-e2e-test branch from 51c7af4 to 6362134 Compare September 17, 2025 16:28
Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the test result before merging.

@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 6362134
  • Duration 2:48:41
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer
Copy link
Member Author

johscheuer commented Sep 18, 2025

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 6362134
  • Duration 2:48:41
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  [FAILED] in [BeforeEach] - /codebuild/output/src1732650022/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/fdb_restore.go:121 @ 09/17/25 17:15:58.948
• [FAILED] [1427.596 seconds]
Operator Backup when a cluster has backups enabled and then restored when the default backup system is used when using a restorable version [BeforeEach] should restore the cluster successfully with a restorable version [e2e, pr]
  [BeforeEach] /codebuild/output/src1732650022/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_backups/operator_backup_test.go:133
  [It] /codebuild/output/src1732650022/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator_backups/operator_backup_test.go:137

  [FAILED] Timed out after 1200.001s.
  Expected
      <v1beta2.FoundationDBRestoreState>: Unknown
  to equal
      <v1beta2.FoundationDBRestoreState>: completed
  In [BeforeEach] at: /codebuild/output/src1732650022/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/fdb_restore.go:121 @ 09/17/25 17:15:58.948

👀

I did a manual run and everything was fine:

-----------------------------
[ReportAfterSuite] Autogenerated ReportAfterSuite for --junit-report
autogenerated by Ginkgo
[ReportAfterSuite] PASSED [0.008 seconds]
------------------------------

Ran 2 of 3 Specs in 454.382 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 1 Skipped
--- PASS: TestOperator (454.39s)
PASS
ok      github.com/FoundationDB/fdb-kubernetes-operator/v2/e2e/test_operator_backups    455.294s

@johscheuer johscheuer closed this Sep 18, 2025
@johscheuer johscheuer reopened this Sep 18, 2025
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 6362134
  • Duration 1:52:00
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Sep 18, 2025
@johscheuer johscheuer reopened this Sep 18, 2025
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 6362134
  • Duration 1:53:55
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer force-pushed the improve-backup-e2e-test branch from 6362134 to 75f4fcb Compare September 19, 2025 08:18
@foundationdb-ci
Copy link
Contributor

Result of fdb-kubernetes-operator-pr on Linux RHEL 9

  • Commit ID: 75f4fcb
  • Duration 2:40:39
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit 605c898 into FoundationDB:main Sep 19, 2025
9 checks passed
@johscheuer johscheuer deleted the improve-backup-e2e-test branch September 19, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants