feat(planning): robust plan JSON repair + schema validation with env toggle #1221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Robust JSON repair and schema validation for LLM-produced plans, plus integration into PlanningFlow with a safe fallback.
Changes
app/planning/
:models.py
(Plan, Step,extra='forbid'
)json_repair.py
(fences, smart quotes, JS comments, trailing commas incl. whitespace, in-string newline/tab escaping, single-missing brace/ bracket balance, 30% sanity guard)collector.py
(extract → repair →json.loads
→Plan.model_validate
)metrics.py
(lightweight counters)integrations.py
(parse_plan_text()
adapter with env toggle)parse_plan_text()
intoapp/flow/planning.py
with a strictjson.loads + Plan.model_validate
fallback.PlanningFlow
.docs/planning-json-repair.md
.Toggle
OPENMANUS_PLANNING_REPAIR=0
.Backwards compatibility / rollback
OPENMANUS_PLANNING_REPAIR=0
to force strict mode.Testing
export PYTHONPATH=$PWD && pytest -q tests/planning
(9 passing).Notes