Deleting a file from the track queue view doesn't delete the file from the device

[marcosox]

Checklist

• I can reproduce the bug with the latest version given here.
• I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected app version

1.2.2

Affected Android/Custom ROM version

Android 8.0

Affected device model

Huawei P10 Lite

How did you install the app?

Google Play Store

Steps to reproduce the bug

1. go to the tracks queue list
2. long tap on a track
3. tap the trash bin icon
4. a popup asks the user for confirmation and warns that this operation will also remove the file from the device
5. confirm

Expected behavior

The file is deleted from the device

Actual behavior

the track entry is removed from the queue, file is still in the device

Screenshots/Screen recordings

No response

Additional information

Looks like deleteTracks() only removes the track from the list, but the delete_song_warning string says that the file will be removed from the device.

I think just blacklisting the file from the queue is fine (I guess it's the icon to the left of the trash bin). As already said in #28, managing files is a file manager's job

[Aga-C]

Have you checked with any file manager if the file is really removed? Removing doesn't trigger rescanning media in Music Player, so it may still be visible in the app.

[naveensingh]

In my case, the file is always deleted, but I can reproduce a queue state issue. Deleting tracks from the queue always deletes the file, but sometimes, the deleted tracks come back as unplayable zombie items (only on the queue page). Updating the queue table in the DB should solve this.

Looks like deleteTracks() only removes the track from the list, but the delete_song_warning string says that the file will be removed from the device.

Music-Player/app/src/main/kotlin/org/fossify/musicplayer/adapters/QueueAdapter.kt

Lines 120 to 122 in be1105b

	context.deleteTracks(selectedTracks) {
	refreshTracksList(positions)
	}

This context.deleteTracks() call in that method does (should) delete the actual file.

[marcosox]

Have you checked with any file manager if the file is really removed?

The file is not removed, that's the issue. I discovered it after the 4th time I deleted some songs and some weeks later I was listening to them again (I must have done a rescan in the meanwhile). I started having doubts about my sanity/memory and decided to finally check the file on the device and verified it isn't getting deleted 🥲

This context.deleteTracks() call in that method does (should) delete the actual file.

Ah, now I see it

I can reproduce a queue state issue. Deleting tracks from the queue always deletes the file, but sometimes, the deleted tracks come back as unplayable zombie items (only on the queue page).

I just made a single-track playlist and deleted the only song in it from the queue view while reproducing it (yeah that's pushing it, I know 😄 ) and the song stayed in the "currently playing" view (stopped and non playable ofc) until I went back to the playlists list view (which is reasonable), but other than that I never experienced zombie tracks after deleting songs.

[naveensingh]

1. go to the tracks queue list

Does it work when you delete a track from somewhere other than the tracks queue list?

[marcosox]

Nope, same from the "artists" view

[naveensingh]

Two more.

• How were those files added? MTP, ADB, or something else?
• Are your files on an SD Card?

[marcosox]

How were those files added? MTP, ADB, or something else?

MTP

Are your files on an SD Card?

yes

[marcosox]

I just tried with a file on the internal memory (added with MTP). This time the file is deleted from the device and the app closes immediately (but I can still see and reopen it from the open apps, I suspect it crashed?)