Skip to content

Conversation

@naveensingh
Copy link
Member

@naveensingh naveensingh commented Oct 12, 2025

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

Updated button state when image compression is skipped due to No limit size preference.

Tests performed

  • Attaching images without text

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@naveensingh naveensingh requested a review from Copilot October 12, 2025 11:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the send button remained disabled when attaching images without text, specifically when compression is skipped due to "No limit" size preference settings.

  • Added logic to update attachment pending state when compression is skipped
  • Updated CHANGELOG.md to document the fix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
app/src/main/kotlin/org/fossify/messages/adapters/AttachmentsAdapter.kt Added conditional check to set isPending to false and call onReady() when compression is skipped
CHANGELOG.md Added changelog entry documenting the bug fix for disabled send button issue

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@naveensingh naveensingh merged commit d0312e0 into main Oct 12, 2025
8 checks passed
@naveensingh naveensingh deleted the naveensingh/fix-disabled-send-button branch October 12, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot only send a photo; app requires text is entered in order to send.

2 participants