Add comprehensive emoji search functionality #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…view This commit introduces a comprehensive emoji search feature and the necessary infrastructure to support it. Key changes include: - Adds a search bar to the emoji palette. - Implements `OtherInputConnection.kt` to handle text input into the `AppCompatAutoCompleteTextView` used for emoji search, allowing the keyboard to type into the search field. - Creates a new view for displaying emoji search results, which shows recent emojis by default and updates based on the user's query. - Adds CSV files (`emoji_category_*.csv`) containing emojis and associated search keywords for various categories (People, Nature, Food, etc.). - Updates `EmojiHelper.kt` to parse the new CSV files and adds a `searchEmojis` function. - Integrates the search logic into `MyKeyboardView.kt`, handling focus changes and text input for the search bar. - Adds new string resources, colors, and a search icon to support the UI changes. - Modifies `SimpleKeyboardIME.kt` to switch between the standard input connection and the new `OtherInputConnection` when the emoji search is active. - Introduces new methods in the `OnKeyboardActionListener` interface for handling search view focus and updating the shift state.
Improve emoji handling and add constants
This commit introduces several improvements to the emoji handling functionality:
- **Refactors emoji search and recents:**
- Defines a `MAX_RECENT_EMOJIS` constant for clarity when retrieving recently used emojis.
- Adds a `MAX_SEARCH_RESULTS` constant to limit the number of emojis returned from a search.
- **Enhances error handling:**
- Improves exception handling in `getEmojisFromAssets` to catch more specific `IOException`, `IllegalArgumentException`, and `IndexOutOfBoundsException` during emoji file parsing.
- Adds specific `IOException` and `JSONException` handling when parsing raw JSON files.
- **Code cleanup:**
- Simplifies conditional logic in `getEmojisFromAssets`.
Replaces the `IndexOutOfBoundsException` catch block with a more general `IOException` to handle potential file reading errors. This provides more robust error logging when processing emoji data files.
Author
|
I'm androidx.emojipicker guy |
Author
|
Dude I'm waiting. Are you reviewing the changes or is something is wrong here, if something has then please mention me, I will fix that |
Member
|
Yes, I'll check this soon. |
Author
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
This pull request introduces a complete emoji search feature to enhance usability and make emoji selection faster and more intuitive.
Key improvements include:
OtherInputConnection.ktto allow typing into theAppCompatAutoCompleteTextViewused for emoji search.emoji_category_*.csv) containing emojis and search keywords for all categories.EmojiHelper.ktto parse the CSV files and added the newsearchEmojisfunction.MyKeyboardView.kt, handling focus changes and input routing.SimpleKeyboardIME.ktto switch between the default input connection andOtherInputConnectionwhen the search view is active.OnKeyboardActionListener.Tests performed
Before & after preview
Video demonstration
Closes the following issue(s)
Checklist