Skip to content

Performance audit for "fwdpp copy" #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Performance audit for "fwdpp copy" #11

merged 1 commit into from
Mar 19, 2024

Conversation

molpopgen
Copy link
Member

No description provided.

@molpopgen molpopgen force-pushed the perf_improvements branch 2 times, most recently from 19808e8 to 95260ad Compare March 18, 2024 21:20
@molpopgen molpopgen mentioned this pull request Mar 18, 2024
@molpopgen molpopgen changed the title avoid extra traversal thru mutation array Performance audit for "fwdpp copy" Mar 18, 2024
* Avoid extra traversal through mutation array
  This change cleans up the logic but doesn't
  improve performance.

* Remove unnecessary mutable iteration

* Remove extra iteration over the haploid genomes each generation

* Implement efficient fixation removal using fwdpp method.
  The new implementation increases overall performace by close to 10%.
@molpopgen molpopgen merged commit 8570922 into main Mar 19, 2024
@molpopgen molpopgen deleted the perf_improvements branch March 19, 2024 15:36
molpopgen added a commit that referenced this pull request Mar 20, 2024
* Uses the same tricks as #11 and #12 did for fwdpp_copy
molpopgen added a commit that referenced this pull request Mar 20, 2024
* Uses the same tricks as #11 and #12 did for fwdpp_copy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant