Repository navigation
No CI: nothing runs npm test or npm run build on pull requests #13
Description
Activity
Gateway hit the same gap and is fixing it there (gateway#140): they had no CI running lint, typecheck, test or build, and found five merged PRs that existed solely to green those gates by hand.
Their framing for why it matters more here than in an app repo, which I agree with: a stale committed build artifact plus no CI is a combination that ships silently. Consumers of this package install by tarball SHA and get the committed
dist/— so ifdist/drifts fromsrc/(which it has: #12), nothing anywhere catches it. Every other Fortium repo at least fails a test run; this one has neither a test gate nor a build-parity gate, and it is the auth client for all of them.That makes the
git diff --exit-code -- packages/*/diststep in the proposal above the load-bearing part, not a nicety — it closes #12's class permanently rather than fixing the one instance.
.github/workflows/does not exist in this repo.gh pr checks 11shows only CodeRabbit (a GitHub App), no test or build job. So a PR here is merged on whatever the author ran locally, and a consumer installing by tarball SHA gets a committeddist/that no automation ever verified matchessrc/— which is exactly the drift already sitting inpackages/admin/dist(#12).This is the auth client library for every Fortium app. It should be the last repo without a test gate, not the only one.
Minimum viable workflow (
pull_request+pushtomain):npm cinpm run build— thengit diff --exit-code -- packages/*/distso a stale committed dist fails the run (closes the packages/admin/dist is stale relative to src — npm run build regenerates 16 files that were never committed #12 class permanently)npm test(the root script already sets--experimental-vm-modules)Same shape as identity's
deploy.ymltestjob minus the postgres service; ~30 lines. Add a required-status-check ruleset scoped to this repo (not the org-level one) once it is green.Evidence for #11 today:
npm test14 suites / 187 tests exit 0 andnpm run buildexit 0 — locally, in the implementer's worktree, and nowhere else.Refs #11, #12