Added VIPGRP functions matching -AddressGroup #89

poundy · 2020-03-05T07:11:41Z

No description provided.

alagoutte · 2020-03-05T22:27:45Z

Thanks !, it will make a quick review,

do you have try all cmdlet ?

PowerFGT/Private/Confirm.ps1

PowerFGT/Public/cmdb/firewall/vipgroup.ps1

poundy · 2020-03-06T00:13:02Z

Thanks !, it will make a quick review,

do you have try all cmdlet ?

Yes, I've tested the full cmdlet suite. Not extensively, but I've done tests on everything on my FW setup.

I've made amendments based on changes requested, but I am not familiar with whether these changes have now been re-submitted into this for approval again or if my "request review" has just been done on the older commit? I saw it re-do the automated checks so I assume at some level those updates have made it here. (sorry for being such a newbie on github and contributions)

alagoutte · 2020-03-06T05:53:04Z

Thanks Brett ! it will make some test (i think no before next week)
but look (very) good !

You can also update README.(md) for add example ;-)

There is no yet unit test (but it is on my roadmap for next release...)

README.md

alagoutte · 2020-03-09T07:11:32Z

Thanks, i will try this week !

alagoutte · 2020-05-02T09:15:29Z

PowerFGT/Public/cmdb/firewall/vipgroup.ps1

+        [string]$name,
+        [Parameter (Mandatory = $true)]
+        [string[]]$member,
+        [Parameter (Mandatory = $true)]


interface is really needed ?

can you check the API docs to confirm it's shown as mandatory there? I am pretty sure that you can't define it without a bound interface via GUI/CLI... just checked and confirmed that Interface is required:
config firewall vipgrp
edit "Brett_Test"
(Brett_Test) # next
Attribute 'interface' MUST be set.
Command fail. Return code 1

it is no specified on API :-/
after, we can use the same idea like for VIP cmdlet (and also GUI), set any by default https://github.com/FortiPower/PowerFGT/blob/master/PowerFGT/Public/cmdb/firewall/vip.ps1#L49

alagoutte · 2020-05-02T09:15:48Z

PowerFGT/Public/cmdb/firewall/vipgroup.ps1

+        }
+        $vipgrp | add-member -name "member" -membertype NoteProperty -Value $members
+
+        if ( $PsBoundParameters.ContainsKey('interface') ) {


if interface is really needed, you need to remove this if

OK, but functionally it works, because there always will be an interface, this tests true always.

(so a more correct statement would be "if interface is really needed, you should remove this redundant if")

amendment complete

alagoutte · 2020-08-25T19:04:38Z

Hi @poundy can you look if it is ok for you ? (i have some test and fix some issue found with when write test...)

@CedricMoreau, can look review too ?

poundy · 2020-09-14T04:15:41Z

Just commenting in here because I am kind of stuck at the moment, not really understanding the push-pull status here on what I can use to test.
I am happy to re-load a cut of the code just can't be sure where I should be grabbing it from? If you could help guide me there, I will get it into my env and test against a 6.2.x device.

alagoutte · 2020-09-14T06:07:40Z

Hi @poundy, i prepare to merge soon this patch (and why i have fix a typo and rebase change!)

poundy · 2020-09-14T06:17:01Z

Hi @poundy, i prepare to merge soon this patch (and why i have fix a typo and rebase change!)

I am happy to load again and add to my (production) tests if that helps; I have been using it in the original form I originally committed although vipgrps aren't something I create a lot of!

CedricMoreau · 2020-09-22T07:15:32Z

README.md

@@ -21,6 +21,7 @@ With this module (version 0.4.1) you can manage:
 - System Global (Get)
 - [VDOM](#VDOM) (Get)
 - [Virtual IP](#Virtual-IP) (Get/Add/Remove object type static-nat)
+- VirtualIPGroup (Add/Get/Copy/Set/Remove and Add/Remove Member)


Use the same format as the one above

Added example for backing up the configuration

Initial commit; untested

Added Confirm-FGTVipGroup for VipGroup operations

AddFGTFirewallVipGroup requires interface in creation

revert unnecessary change

Feedback from PR

Updated base readme.md with VIPGRP related functions list. Did not expand on use caes for vipgrp.

updated based on mandatory INTERFACE property, nullifying the need for a test

and also it is not a string array for interface

alagoutte · 2020-10-06T20:48:13Z

Thanks @poundy and sorry for delay ;-)

poundy mentioned this pull request Mar 5, 2020

Add VIPGRP functions #88

Closed

alagoutte requested changes Mar 5, 2020

View reviewed changes

PowerFGT/Private/Confirm.ps1 Outdated Show resolved Hide resolved

PowerFGT/Public/cmdb/firewall/vipgroup.ps1 Outdated Show resolved Hide resolved

PowerFGT/Public/cmdb/firewall/vipgroup.ps1 Outdated Show resolved Hide resolved

poundy requested a review from alagoutte March 6, 2020 00:10

alagoutte reviewed Mar 7, 2020

View reviewed changes

README.md Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

poundy requested a review from alagoutte March 7, 2020 21:22

alagoutte added this to the 0.5.0 milestone Mar 10, 2020

alagoutte mentioned this pull request Mar 14, 2020

Testing #93

Closed

alagoutte reviewed May 2, 2020

View reviewed changes

alagoutte force-pushed the master branch 2 times, most recently from d04ddc0 to aa5e8ec Compare August 25, 2020 07:05

alagoutte force-pushed the master branch from e6ad136 to efe17b0 Compare September 13, 2020 09:20

CedricMoreau approved these changes Sep 21, 2020

View reviewed changes

CedricMoreau reviewed Sep 22, 2020

View reviewed changes

poundy added 8 commits September 22, 2020 21:48

Update Invoke-FGTRestMethod.md

034fab9

Added example for backing up the configuration

Create vipgroup.ps1

a651451

Initial commit; untested

Update Confirm.ps1

2a29286

Added Confirm-FGTVipGroup for VipGroup operations

Update vipgroup.ps1

b90a831

AddFGTFirewallVipGroup requires interface in creation

Update Invoke-FGTRestMethod.md

0ab36e6

revert unnecessary change

Update vipgroup.ps1

e3f0033

Feedback from PR

Update vipgroup.ps1

e371772

Update Confirm.ps1

1d3ed93

poundy and others added 16 commits September 22, 2020 21:48

Update vipgroup.ps1

b49d7a9

Update README.md

10e72e9

Updated base readme.md with VIPGRP related functions list. Did not expand on use caes for vipgrp.

Update README.md

cc83de0

Update README.md

8b1a0d4

Update vipgroup.ps1

9c29718

updated based on mandatory INTERFACE property, nullifying the need for a test

vipgroup: fix header and missing blank line

38626dc

vipgroup: set interface by default to any (like for vip)

1b5f425

and also it is not a string array for interface

VIPGroup: Use ShouldProcess (remove PSSA warning)

66dce7a

VIPGroup: Fix when remove member (and there is only one member)

5ab3b60

VIPGroup: Add TODO about interface

bad0236

VIPGroup: there is no visibility field...

63aeb6c

VIPGroup: it is commentS (and not comment...)

9661fc3

VipGroup(Tests): Add Tests for VIP Group (Add/Copy/Get/Set/Remove)

dd2ebc9

VIPGroup: Fix typo on tests...

b52a3af

Confirm(VIPGroup): fix typo (a -> an)

dee4f04

README(.md): enhance Virtual IP (Group) list

884a6f6

alagoutte force-pushed the master branch from efe17b0 to 884a6f6 Compare September 22, 2020 19:59

alagoutte merged commit 701eb88 into FortiPower:master Oct 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added VIPGRP functions matching -AddressGroup #89

Added VIPGRP functions matching -AddressGroup #89

poundy commented Mar 5, 2020

alagoutte commented Mar 5, 2020

poundy commented Mar 6, 2020

alagoutte commented Mar 6, 2020

alagoutte commented Mar 9, 2020

alagoutte May 2, 2020

poundy May 3, 2020

alagoutte May 4, 2020

alagoutte May 2, 2020

poundy May 3, 2020

poundy May 3, 2020

poundy May 3, 2020

alagoutte commented Aug 25, 2020

poundy commented Sep 14, 2020

alagoutte commented Sep 14, 2020

poundy commented Sep 14, 2020

CedricMoreau Sep 22, 2020

alagoutte commented Oct 6, 2020

Added VIPGRP functions matching *-AddressGroup* #89

Added VIPGRP functions matching *-AddressGroup* #89

Conversation

poundy commented Mar 5, 2020

alagoutte commented Mar 5, 2020

poundy commented Mar 6, 2020

alagoutte commented Mar 6, 2020

alagoutte commented Mar 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alagoutte commented Aug 25, 2020

poundy commented Sep 14, 2020

alagoutte commented Sep 14, 2020

poundy commented Sep 14, 2020

Choose a reason for hiding this comment

alagoutte commented Oct 6, 2020

Added VIPGRP functions matching -AddressGroup #89

Added VIPGRP functions matching -AddressGroup #89