Improved logic for Gradle plugin dependency including and advance enable detection
#86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the handling of compilations in the Gradle plugin appeared to be such that only one compilation was allowed in a
sourceSet, otherwise an exception would be thrown.But in android it seems that there may be more than one
compilationin a source set, e.g., there are twocompilations[debug,release] in source setandroidMain.Under the old logic, this would have thrown an exception, which is what led to #85.
Now, in Kotlin multiplatform projects,
SourceSet.dependenciesare set based on all compilations, rather thanProject.dependenciesbeing configured after the first compilation.And
enableis detected much earlier.Fix #85