- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5
 
Release: v2.2.20-0.13.1 #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e8715b2
              bd19577
              55eed6f
              ebad6bf
              19b8740
              3ae9499
              17ec6dd
              71a1589
              0c53db8
              File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Kotlin version: `v2.2.20` | 
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Kotlin version: `v2.2.20-Beta1` | 
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 
          
            
          
           | 
    @@ -165,7 +165,7 @@ class SuspendTransformFirTransformer( | |||||||||||||
| } | ||||||||||||||
| 
     | 
||||||||||||||
| private val cache: FirCache<FirCacheKey, Map<Name, Map<FirNamedFunctionSymbol, SyntheticFunData>>?, Nothing?> = | ||||||||||||||
| session.firCachesFactory.createCache { cacheKey, c -> | ||||||||||||||
| session.firCachesFactory.createCache { cacheKey, _ -> | ||||||||||||||
| val (symbol, scope) = cacheKey | ||||||||||||||
| initScopeSymbol() | ||||||||||||||
| val transformerFunctionMap = initTransformerFunctionSymbolMap(symbol, scope) | ||||||||||||||
| 
          
            
          
           | 
    @@ -212,7 +212,7 @@ class SuspendTransformFirTransformer( | |||||||||||||
| ): List<FirValueParameter> { | ||||||||||||||
| return map { vp -> | ||||||||||||||
| buildValueParameterCopy(vp) { | ||||||||||||||
| symbol = FirValueParameterSymbol(vp.symbol.name) | ||||||||||||||
| symbol = FirValueParameterSymbol() | ||||||||||||||
| containingDeclarationSymbol = newContainingDeclarationSymbol | ||||||||||||||
| 
     | 
||||||||||||||
| val copiedConeType = vp.returnTypeRef.coneTypeOrNull | ||||||||||||||
| 
          
            
          
           | 
    @@ -348,11 +348,11 @@ class SuspendTransformFirTransformer( | |||||||||||||
| newFunTarget: FirFunctionTarget, | ||||||||||||||
| transformer: Transformer | ||||||||||||||
| ): FirBlock = buildBlock { | ||||||||||||||
| this.source = originFunc.body?.source | ||||||||||||||
| 
     | 
||||||||||||||
| this.source = originFunSymbol.bodySource ?: originFunSymbol.source | ||||||||||||||
| // lambda: suspend () -> T | ||||||||||||||
| val lambdaTarget = FirFunctionTarget(null, isLambda = true) | ||||||||||||||
| val lambda = buildAnonymousFunction { | ||||||||||||||
| this.source = originFunSymbol.bodySource ?: originFunSymbol.source | ||||||||||||||
| this.resolvePhase = FirResolvePhase.BODY_RESOLVE | ||||||||||||||
| // this.resolvePhase = FirResolvePhase.RAW_FIR | ||||||||||||||
| this.isLambda = true | ||||||||||||||
| 
          
            
          
           | 
    @@ -701,7 +701,7 @@ class SuspendTransformFirTransformer( | |||||||||||||
| val (functionAnnotations, propertyAnnotations, includeToOriginal) = | ||||||||||||||
| copyAnnotations(original, funData) | ||||||||||||||
| 
     | 
||||||||||||||
| val pSymbol = FirPropertySymbol(callableId) | ||||||||||||||
| val pSymbol = FirRegularPropertySymbol(callableId) | ||||||||||||||
        
    
 | 
||||||||||||||
| val pSymbol = FirRegularPropertySymbol(callableId) | |
| // Use FirPropertySymbol to allow for synthetic property creation if needed. | |
| val pSymbol: FirPropertySymbol = FirRegularPropertySymbol(callableId) | 
    
      
    
      Copilot
AI
    
    
    
      Sep 12, 2025 
    
  
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The massive simplification of the override checking logic removes important validation steps. The original code verified receiver types, parameter counts, and parameter types before determining override status. This simplified version may incorrectly mark functions as overrides.
    
      
    
      Copilot
AI
    
    
    
      Sep 12, 2025 
    
  
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added null-safe operator ?. to callableId access. While this prevents null pointer exceptions, it may hide underlying issues where callableId should not be null. Consider investigating why callableId might be null and handle it more explicitly.
| .filter { it.callableId?.callableName == functionName } | |
| .filter { | |
| val callableId = it.callableId | |
| requireNotNull(callableId) { "Property symbol ${it} has null callableId, which should not happen." } | |
| callableId.callableName == functionName | |
| } | 
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1 +1 @@ | ||
| {"version": "2.2.10-0.13.1"} | ||
| {"version": "2.2.20-0.13.1"} | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the name parameter from FirValueParameterSymbol() constructor may cause issues with parameter identification. The original code
FirValueParameterSymbol(vp.symbol.name)preserved parameter naming which could be important for debugging and reflection.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?