Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bath is not code #18440

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

lubber-de
Copy link

The "bath" icon was part of the "code" category which is obviously misplaced 🙂

We always generate the icon list out of the category.json in Fomantic-UI and our users came across this here

https://twitter.com/LizzyReborn/status/1458308094258294786

image

I understand that:

  • I'm submitting this PR for reference only. It shows an example of what I'd like to see changed but
    I understand that it will not be merged and I will not be listed as a contributor on this project.

@tagliala
Copy link
Member

Hi!

Thanks for being part of the Font Awesome Community and thanks for reporting this.

This should be fixed in the upstream repository, let's assign @talbs

@LizAinslie
Copy link

Hi! User who originally posted this speaking!

I find that barcode also feels out of place in its current category (though it makes a heck of a lot more sense than bath) and some of the replies stated this as well. I can submit a separate PR for that if need be.

@tagliala
Copy link
Member

I find that barcode also feels out of place in its current category (though it makes a heck of a lot more sense than bath) and some of the replies stated this as well. I can submit a separate PR for that if need be.

Feel free to open a new issue, since we can't merge PRs because the category file in this repo is being generated by an upstream build system

@LizAinslie
Copy link

Alright, got it; I'll submit an issue later today, thanks!

@talbs talbs removed their assignment May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants