fix(FOROME-1626): numeric condition strictness signs

ForomePlatform · Sep 6, 2022 · ecc7bad · ecc7bad
1 parent 51c12a2
commit ecc7bad
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 18 deletions.
diff --git a/src/components/conditions/numeric/numeric-condition-range.tsx b/src/components/conditions/numeric/numeric-condition-range.tsx
@@ -1,7 +1,6 @@
 import React, { ReactElement, useCallback, useMemo, useState } from 'react'
 import cn from 'classnames'
 
-import { NumericSelectTypes } from '@core/enum/numeric-select-types-enum'
 import { adjustHistogramData } from '@core/histograms'
 import { t } from '@i18n'
 import { Checkbox } from '@ui/checkbox/checkbox'
@@ -123,7 +122,6 @@ export const NumericConditionRange = ({
             <div className="grow-0 mx-2">
               <StrictnessSelect
                 value={minStrictness}
-                selectType={NumericSelectTypes.Min}
                 onChange={v => updateValue(NumericValueIndex.MinStrictness, v)}
                 isDisabled={isZeroIncluded}
               />
@@ -140,7 +138,6 @@ export const NumericConditionRange = ({
             <div className="grow-0 mx-2">
               <StrictnessSelect
                 value={maxStrictness}
-                selectType={NumericSelectTypes.Max}
                 onChange={v => updateValue(NumericValueIndex.MaxStrictness, v)}
               />
             </div>

diff --git a/src/components/conditions/numeric/strictness-select/strictness-select-button.tsx b/src/components/conditions/numeric/strictness-select/strictness-select-button.tsx
@@ -1,29 +1,23 @@
 import { ReactElement, useMemo } from 'react'
 import cn from 'classnames'
 
-import { NumericSelectTypes } from '@core/enum/numeric-select-types-enum'
 import { Icon } from '@ui/icon'
 
 interface IStrictnessSelectButtonProps {
   value: boolean
-  selectType: NumericSelectTypes
   onChange: (newValue: boolean) => void
   disabled?: boolean
 }
 
 export const StrictnessSelectButton = ({
   disabled,
   value,
-  selectType,
   onChange,
 }: IStrictnessSelectButtonProps): ReactElement => {
   const strictnessSign = useMemo(() => {
     return value ? <Icon name="LessOrEqualThan" /> : <Icon name="LessThan" />
   }, [value])
 
-  const signDirection =
-    selectType === NumericSelectTypes.Min ? 'scale(-1,1)' : ''
-
   return (
     <button
       className={cn(
@@ -35,7 +29,6 @@ export const StrictnessSelectButton = ({
       onClick={() => onChange(value ? false : true)}
     >
       <div
-        style={{ transform: signDirection }}
         className={cn(
           'flex items-center justify-center w-full h-full rounded',
           disabled

diff --git a/src/components/conditions/numeric/strictness-select/strictness-select.tsx b/src/components/conditions/numeric/strictness-select/strictness-select.tsx
@@ -1,25 +1,21 @@
 import { ReactElement } from 'react'
 
-import { NumericSelectTypes } from '@core/enum/numeric-select-types-enum'
 import { StrictnessSelectButton } from './strictness-select-button'
 
 export interface IStrictnessSelectProps {
   value: boolean
-  selectType: NumericSelectTypes
   onChange: (newValue: boolean) => void
   isDisabled?: boolean
 }
 
 export const StrictnessSelect = ({
   value,
-  selectType,
   onChange,
   isDisabled,
 }: IStrictnessSelectProps): ReactElement => (
   <StrictnessSelectButton
     value={value}
     disabled={isDisabled}
-    selectType={selectType}
     onChange={onChange}
   />
 )
diff --git a/src/core/enum/numeric-select-types-enum.ts b/src/core/enum/numeric-select-types-enum.ts