Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lodash isNil and isNan with native code #2800

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Feb 12, 2024

Replace lodash isNil and isNan with native code.

isNil

Replaced with code directly from the lodash code base which is:

export function isNil(value: any): boolean {
  return value == null;
}

isNan

The ES6 equivalent of lodash isNan is Number.isNan

Copy link

changeset-bot bot commented Feb 12, 2024

🦋 Changeset detected

Latest commit: ecc4269

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-area Patch
victory-bar Patch
victory-box-plot Patch
victory-candlestick Patch
victory-core Patch
victory-errorbar Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-pie Patch
victory-scatter Patch
victory-voronoi Patch
victory-axis Patch
victory-brush-container Patch
victory-brush-line Patch
victory-canvas Patch
victory-chart Patch
victory-create-container Patch
victory-cursor-container Patch
victory-group Patch
victory-native Patch
victory-polar-axis Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-zoom-container Patch
victory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 7:03pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants