Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cyclic deps from tests #2795

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Remove cyclic deps from tests #2795

merged 2 commits into from
Feb 9, 2024

Conversation

carbonrobot
Copy link
Contributor

Remove cyclic dependencies from unit tests. This solves the cyclic dependency warnings when using pnpm install.

  • Removes the victory-core dependency on victory-axis and victory-line and uses mocks. Core is a dependency for all other packages so it can not have a dependency on any of them
  • Removes a test from victory-axis that was a duplicate of the same test in victory-chart
  • Pins all local dev dependencies to * to avoid issues where it tries to download a real npm module'

This is a precursor to more jest improvements in #2793

Pin victory-native to legacy
Copy link

changeset-bot bot commented Feb 9, 2024

⚠️ No Changeset found

Latest commit: 9ce3d08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 4:06pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants