Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Victory native type fixes #2785

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Victory native type fixes #2785

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a737fa
Fix wrapCoreComponent HOC types
KenanYusuf Feb 6, 2024
6457474
Fix container mixin types
KenanYusuf Feb 6, 2024
f6b3206
remove unused types
KenanYusuf Feb 6, 2024
e693496
Fix victory-native component prop types
KenanYusuf Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused types
  • Loading branch information
@KenanYusuf
KenanYusuf committed Feb 6, 2024
commit f6b32060dc7d1157b2468c2faf6ae282acde0d7c
1 change: 0 additions & 1 deletion packages/victory-brush-container/src/victory-brush-container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,4 +216,3 @@ export const brushContainerMixin = <TBase extends Constructor>(base: TBase) =>
};

export const VictoryBrushContainer = brushContainerMixin(VictoryContainer);
export type VictoryBrushContainer = typeof VictoryBrushContainer;
1 change: 0 additions & 1 deletion packages/victory-cursor-container/src/victory-cursor-container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,4 +210,3 @@ export function cursorContainerMixin<
}

export const VictoryCursorContainer = cursorContainerMixin(VictoryContainer);
export type VictoryCursorContainer = typeof VictoryCursorContainer;
1 change: 0 additions & 1 deletion packages/victory-selection-container/src/victory-selection-container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,4 +120,3 @@ export function selectionContainerMixin<

export const VictorySelectionContainer =
selectionContainerMixin(VictoryContainer);
export type VictorySelectionContainer = typeof VictorySelectionContainer;
Copy link
Contributor Author

@KenanYusuf KenanYusuf Feb 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These types are no longer necessary for typing the victory-native container components

Loading