Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tests for victory error bar #2266

Merged
merged 2 commits into from
May 28, 2022
Merged

Convert tests for victory error bar #2266

merged 2 commits into from
May 28, 2022

Conversation

becca-bailey
Copy link
Contributor

@becca-bailey becca-bailey commented May 27, 2022

This is part of #2195

This also includes removing the renderInSvg function and using { wrapper: 'svg' } instead. I meant to push up this change as a separate PR, but it ended up here instead.

@becca-bailey becca-bailey added this to the Overhaul Testing milestone May 27, 2022
Copy link
Member

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comments.

Copy link
Contributor

@heythisispaul heythisispaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few opinions on changing some assertion syntax, but this looks good to me!

@becca-bailey becca-bailey merged commit 04ffa01 into main May 28, 2022
@becca-bailey becca-bailey deleted the chore/victory-tests branch May 28, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants