Cache sharedEvents prop to prevent re-renders #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements caching the
sharedEventsprop created byvictory-shared-eventsto prevent re-renders, which improves the performance of Victory container components.TL;DR
VictoryCursorContainer- significant performance increaseVictorySelectionContainer- significant performance increaseVictoryBrushContainer- significant performance increase in uncontrolled cases (ie doesn't re-render on each mousemove)VictoryVoronoiContainer- small - medium performance increase, with more sparsely positioned data getting more of a performance increaseVictoryZoomContainer- should have a small increase due to not re-rendering axes in uncontrolled casesBefore and After
Cursor Container
Example 1 (1500 points) - 56% decrease in scripting
Before
After
Example 2 (1500 bars) - 12% decrease in scripting + no dropped frames
Before
After
Example 3 (10 points) - neglible increase in scripting
Before
After
Selection Container
Example 1 (400 points) - 39% decrease in scripting
Before
After
Example 2 (50 points) - 42% decrease in scripting
Before
After
Example 3 - 48% decrease in scripting
Before
After
Voronoi Container
Example 1 - negilible increase
Before
After
Example 2 - about the same
Before
After
Example 3 - 9% decrease in scripting
Before
After
Brush Container
Example 1 - 46% decrease in scripting
Before
After