Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo for box plot, clean up label prop defs for box plot #1508

Merged
merged 3 commits into from
Apr 14, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add demo for box plot, clean up label prop defs for box plot
  • Loading branch information
maddles committed Apr 8, 2020
commit 95254643d35f26280e31d440003046b2f243d9e2
2 changes: 2 additions & 0 deletions demo/ts/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { keys } from "lodash";
import AreaDemo from "./components/victory-area-demo";
import AxisDemo from "./components/victory-axis-demo";
import BarDemo from "./components/victory-bar-demo";
import BoxPlotDemo from "./components/victory-box-plot-demo";
import ChartDemo from "./components/victory-chart-demo";
import LegendDemo from "./components/victory-legend-demo";
import LineDemo from "./components/victory-line-demo";
Expand All @@ -15,6 +16,7 @@ const MAP = {
"/axis": { component: AxisDemo, name: "AxisDemo" },
"/area": { component: AreaDemo, name: "AreaDemo" },
"/bar": { component: BarDemo, name: "BarDemo" },
"/box-plot": { component: BoxPlotDemo, name: "BoxPlotDemo" },
"/chart": { component: ChartDemo, name: "ChartDemo" },
"/line": { component: LineDemo, name: "LineDemo" },
"/tooltip": { component: TooltipDemo, name: "TooltipDemo" },
Expand Down
207 changes: 207 additions & 0 deletions demo/ts/components/victory-box-plot-demo.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,207 @@
/*global window:false */
/*eslint-disable no-magic-numbers */
import React from "react";
import { VictoryChart } from "@packages/victory-chart/src/index";
import { VictoryBoxPlot } from "@packages/victory-box-plot/src/index";
import { VictoryTheme } from "@packages/victory-core/src/index";
import { range, random } from "lodash";

interface VictoryBoxPlotDemoState {
data: {
x: number;
y: number[];
}[];
}

export default class VictoryBoxPlotDemo extends React.Component<any, VictoryBoxPlotDemoState> {
setStateInterval?: number = undefined;

constructor(props: any) {
super(props);
this.state = {
data: this.getData()
};
}

componentDidMount() {
this.setStateInterval = window.setInterval(() => {
this.setState({
data: this.getData()
});
}, 3000);
}

componentWillUnmount() {
window.clearInterval(this.setStateInterval);
}

getData() {
return range(5).map((i) => {
return {
x: i,
y: range(20).map(() => random(1, 100))
};
});
}

render() {
const containerStyle: React.CSSProperties = {
display: "flex",
flexDirection: "row",
flexWrap: "wrap",
alignItems: "center",
justifyContent: "center"
};

const chartStyle = { parent: { border: "1px solid #ccc", margin: "2%", maxWidth: "40%" } };

return (
<div className="demo" style={containerStyle}>
<VictoryChart style={chartStyle} minDomain={0} theme={VictoryTheme.material}>
<VictoryBoxPlot
minLabels
maxLabels
data={[
{ x: "red", y: [5, 10, 9, 2] },
{ x: "blue", y: [1, 15, 6, 8] },
{ x: "green", y: [3, 5, 6, 9] },
{ x: "yellow", y: [5, 20, 8, 12] },
{ x: "white", y: [2, 11, 12, 13] }
]}
/>
</VictoryChart>
<VictoryChart style={chartStyle}>
<VictoryBoxPlot
data={[{ x: 1, y: 10 }, { x: 1, y: 7 }, { x: 1, y: 3 }, { x: 1, y: 5 }]}
/>
</VictoryChart>
<VictoryChart style={chartStyle} domain={{ x: [0, 3], y: [0, 20] }}>
<VictoryBoxPlot
boxWidth={20}
labels
data={[{ x: 1, y: [5, 10, 9, 2] }, { x: 2, y: [1, 15, 6, 8] }]}
style={{
min: { stroke: "black", strokeWidth: 2 },
max: { stroke: "black", strokeWidth: 2 },
q1: { fill: "#FF530D", fillOpacity: "0.5" },
q3: { fill: "#2bbee0", fillOpacity: "0.5" },
median: { stroke: "#fff", strokeWidth: "4" },
minLabels: { fill: "green", padding: 10 },
maxLabels: { fill: "orange", padding: 10 },
q1Labels: { padding: 10 },
q3Labels: { padding: 10 },
medianLabels: { padding: 10 }
}}
/>
</VictoryChart>

<VictoryChart horizontal style={chartStyle} domain={{ y: [0, 20], x: [0, 3] }}>
<VictoryBoxPlot
minLabels
maxLabels
q1Labels={({ datum }) => `x: ${datum.x}`}
whiskerWidth={50}
data={[{ x: 1, y: [5, 10, 9, 2] }, { x: 2, y: [1, 15, 6, 8] }]}
boxWidth={20}
labelOrientation={"top"}
events={[
{
target: "q1",
eventHandlers: {
onClick: () => {
return [
{
target: "q1Labels",
mutation: () => ({ text: "LABEL!" })
}
];
}
}
}
]}
style={{
min: { stroke: "black", strokeWidth: 2 },
max: { stroke: "black", strokeWidth: 2 },
q1: { fill: "#FF530D", fillOpacity: 0.5 },
q3: { fill: "#2bbee0", fillOpacity: 0.5 },
median: { stroke: "#fff", strokeWidth: 2 },
minLabels: { fill: "green", padding: 10 },
maxLabels: { fill: "orange", padding: 10 }
}}
/>
</VictoryChart>

<VictoryChart style={chartStyle} horizontal domainPadding={50}>
<VictoryBoxPlot
minLabels
maxLabels
boxWidth={10}
data={[
{ x: new Date(1980, 1, 1), y: [5, 10, 9, 2] },
{ x: new Date(1990, 1, 1), y: [1, 15, 6, 8] },
{ x: new Date(2000, 1, 1), y: [3, 5, 6, 9] },
{ x: new Date(2010, 1, 1), y: [5, 20, 8, 12] },
{ x: new Date(2020, 1, 1), y: [2, 11, 12, 13] }
]}
/>
</VictoryChart>
<VictoryChart style={chartStyle} domainPadding={50}>
<VictoryBoxPlot
minLabels
maxLabels
boxWidth={10}
data={[
{ x: "red", y: [5, 10, 9, 2] },
{ x: "blue", y: [1, 15, 6, 8] },
{ x: "green", y: [3, 5, 6, 9] },
{ x: "yellow", y: [5, 20, 8, 12] },
{ x: "white", y: [2, 11, 12, 13] }
]}
/>
</VictoryChart>
<VictoryChart style={chartStyle} domainPadding={50}>
<VictoryBoxPlot
minLabels
maxLabels
boxWidth={10}
data={[
{ x: 1, y: 5 },
{ x: 1, y: 10 },
{ x: 1, y: 8 },
{ x: 2, y: 1 },
{ x: 2, y: 15 },
{ x: 2, y: 7 },
{ x: 3, y: 3 },
{ x: 3, y: 8 },
{ x: 3, y: 5 }
]}
/>
</VictoryChart>
<VictoryChart style={chartStyle} domainPadding={50}>
<VictoryBoxPlot
labels
boxWidth={10}
horizontal
x="type"
data={[
{ type: 1, min: 1, max: 18, median: 8, q1: 5, q3: 15 },
{ type: 2, min: 4, max: 20, median: 10, q1: 7, q3: 15 },
{ type: 3, min: 3, max: 12, median: 6, q1: 5, q3: 10 }
]}
labelOrientation={{
q1: "top",
q3: "top",
min: "bottom",
max: "bottom",
median: "bottom"
}}
/>
</VictoryChart>
<VictoryChart horizontal animate style={chartStyle} domainPadding={50}>
<VictoryBoxPlot boxWidth={10} data={this.state.data} />
</VictoryChart>
<VictoryBoxPlot animate style={chartStyle} boxWidth={10} data={this.state.data} />
</div>
);
}
}
22 changes: 21 additions & 1 deletion packages/victory-box-plot/src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,20 @@ import {
EventPropTypeInterface,
DomainPropType,
DomainPaddingPropType,
OrientationTypes,
StringOrNumberOrCallback,
VictoryDatableProps,
VictoryCommonProps,
VictoryStyleInterface,
VictoryStyleObject
} from "victory-core";

export type VictoryBoxPlotLabelType =
| boolean
| any[]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure about this... should we be enforcing strings and numbers rather than any?

Copy link
Contributor

@boygirl boygirl Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think victory-core exposes a StringOrNumberOrCallback type that would be useful here rather than the plain function.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, actually I guess it's a bit different for VictoryBoxPlot, but you might be able to borrow some of the ideas from https://github.com/FormidableLabs/victory/blob/master/packages/victory-core/src/index.d.ts#L109

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And yes, let's use string | number instead of any

| Function
| { (data: any): string | null }

export interface VictoryBoxPlotStyleInterface extends VictoryStyleInterface {
max?: VictoryStyleObject;
maxLabels?: VictoryStyleObject;
Expand All @@ -34,30 +41,43 @@ export interface VictoryBoxPlotStyleInterface extends VictoryStyleInterface {
q3Labels?: VictoryStyleObject;
}

export interface VictoryBoxPlotLabelOrientationInterface extends VictoryStyleInterface {
max?: OrientationTypes;
min?: OrientationTypes;
median?: OrientationTypes;
q1?: OrientationTypes;
q3?: OrientationTypes;
}

export interface VictoryBoxPlotProps extends VictoryCommonProps, VictoryDatableProps {
boxWidth?: number;
domain?: DomainPropType;
domainPadding?: DomainPaddingPropType;
events?: EventPropTypeInterface<string, StringOrNumberOrCallback>[];
eventKey?: StringOrNumberOrCallback;
horizontal?: boolean;
labelOrientation?: "top" | "bottom" | "left" | "right";
labelOrientation?: OrientationTypes | VictoryBoxPlotLabelOrientationInterface;
labels?: boolean;
max?: StringOrNumberOrCallback | string[];
maxComponent?: React.ReactElement;
maxLabelComponent?: React.ReactElement;
maxLabels?: VictoryBoxPlotLabelType;
median?: StringOrNumberOrCallback | string[];
medianComponent?: React.ReactElement;
medianLabelComponent?: React.ReactElement;
medianLabels?: VictoryBoxPlotLabelType;
min?: StringOrNumberOrCallback | string[];
minComponent?: React.ReactElement;
minLabelComponent?: React.ReactElement;
minLabels?: VictoryBoxPlotLabelType;
q1?: StringOrNumberOrCallback | string[];
q1Component?: React.ReactElement;
q1LabelComponent?: React.ReactElement;
q1Labels?: VictoryBoxPlotLabelType;
q3?: StringOrNumberOrCallback | string[];
q3Component?: React.ReactElement;
q3LabelComponent?: React.ReactElement;
q3Labels?: VictoryBoxPlotLabelType;
style?: VictoryBoxPlotStyleInterface;
whiskerWidth?: number;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/victory-tooltip/src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export interface FlyoutProps extends VictoryCommonProps {
height?: number;
id?: string | number;
index?: number;
orientation?: "top" | "bottom" | "left" | "right";
orientation?: OrientationTypes;
origin?: object;
pathComponent?: React.ReactElement;
pointerLength?: number;
Expand Down