Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aria problem: VictoryContainer creates elements with same id #382

Closed
cowboy opened this issue Oct 4, 2016 · 1 comment
Closed

Aria problem: VictoryContainer creates elements with same id #382

cowboy opened this issue Oct 4, 2016 · 1 comment
Labels
Status: Needs More Info ✋ A question or report that needs more info to be addressable Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@cowboy
Copy link

cowboy commented Oct 4, 2016

Looking at the VictoryContainer source I noticed that each VictoryContainer creates elements with the fixed ids of title and desc.

What happens when there are multiple VictoryContainer in the same page? Don't id attributes need to be unique?
@boygirl boygirl added Type: Bug 🐛 Oh no! A bug or unintentional behavior Status: Needs More Info ✋ A question or report that needs more info to be addressable labels Mar 11, 2017
@chrisbolin
Copy link
Contributor

definitely an issue. we have multiple tickets open for this, so I am closing this in favor of #515

boygirl added a commit that referenced this issue Jul 17, 2018
@boygirl
Merge pull request #382 from FormidableLabs/bug/y0
9650a78 
fix y0 domain bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs More Info ✋ A question or report that needs more info to be addressable Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cowboy @chrisbolin @boygirl