Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifying categorical data causes confusion #350

Closed
Assignees

Comments

@boygirl
Copy link
Contributor

boygirl commented Sep 16, 2016

From @boygirl on June 22, 2016 20:0

Currently categorical data is handled by creating a string map, and replacing string x values with mapped numeric values and storing the associated strings as xName. This becomes confusing when users are trying to work with functional styles and props. Rather than modifying x we should be creating a new property on the data objects that will be used always. Maybe victoryX and victoryY

Copied from original issue: FormidableLabs/victory-chart#257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant