Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

victory-legend #35

Closed
boygirl opened this issue Nov 10, 2015 · 14 comments
Closed

victory-legend #35

boygirl opened this issue Nov 10, 2015 · 14 comments
Labels
Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release

Comments

@boygirl
Copy link
Contributor

boygirl commented Nov 10, 2015

No description provided.

@boygirl boygirl reopened this Nov 10, 2015
@knowbody
Copy link
Contributor

knowbody commented Jan 4, 2016

@boygirl can you give more details on this, please

@knowbody knowbody added the Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release label Jan 4, 2016
@boygirl
Copy link
Contributor Author

boygirl commented Jan 4, 2016

This should be a box with colored symbols / lines and corresponding data series names. It should take an array of colors, symbols, and names, as well as an absolute position x, y. Chart should be able to generate one for its child data, and should also be able to use a user provided legend component, and auto fill it with missing props. i.e. names / colors from data.

@joanllenas
Copy link

+1

@backnotprop
Copy link
Contributor

http://bl.ocks.org/bobmonteverde/2070123

legend with colored circles would be cool ...

@boygirl
Copy link
Contributor Author

boygirl commented Feb 12, 2016

@knowbody are you interested in giving this feature a shot? Let me know if so, and we can chat and make sure we're on the same page about requirements

@knowbody
Copy link
Contributor

@boygirl yup, I'll ping you with some code, once I have something

@knowbody knowbody self-assigned this Feb 12, 2016
@knowbody
Copy link
Contributor

I have no time to do it this week, but will try next week.

divmain pushed a commit that referenced this issue Feb 16, 2016
Support independent axis on the left or right
divmain pushed a commit that referenced this issue Feb 16, 2016
Add basic docs and playgrounds.
divmain pushed a commit that referenced this issue Feb 16, 2016
@StevenLangbroek
Copy link

@boygirl can you assign the ticket to me? thanks :)

@adammenges
Copy link

Is this on track for release at the end of the month? 🎉

@ekmartin
Copy link

ekmartin commented Jul 4, 2016

Any update on this? Would be really cool 👍

@ghost
Copy link

ghost commented Jul 17, 2016

Hi, I'd like to take a shot at this issue. Can you let me know what the requirements are?

@boygirl
Copy link
Contributor Author

boygirl commented Jul 19, 2016

@ahmedghoneim92 the reason this feature hasn't been started has a lot to do with nailing down the requirements actually! But it you'd like to get stated on something generic, it should live in the victory-core repo. You can chat with me in the gitter channel about collaborating https://gitter.im/FormidableLabs/victory

@dandelany
Copy link
Contributor

FWIW I've used this library before, it may be a good starting point for determining requirements:

http://d3-legend.susielu.com/

@boygirl boygirl added this to the September milestone Sep 1, 2016
@angelanicholas
Copy link
Contributor

Fixed in FormidableLabs/victory-core#189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release
Projects
None yet
Development

No branches or pull requests

10 participants