Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add radium and lodash to component package.json files #176

Closed
11 tasks done
coopy opened this issue Jan 19, 2016 · 0 comments
Closed
11 tasks done

Add radium and lodash to component package.json files #176

coopy opened this issue Jan 19, 2016 · 0 comments
Assignees
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@coopy
Copy link
Contributor

coopy commented Jan 19, 2016

We need to move all application dependencies from the archetype to each individual Victory repo. We currently specify radium and lodash in the archetype.

Repos

  • builder-victory-component
  • victory (update last, once we've pushed new versions of everything)
  • victory-animation
  • victory-axis
  • victory-bar
  • victory-chart
  • victory-label
  • victory-line
  • victory-pie
  • victory-scatter
  • victory-component-boilerplate

Explanation

The only way to guarantee a specific dependency version (excluding npm shrinkwrap) is to specify the dependency in the project.

Example of problem manifesting:

  1. $ git clone https://github.com/coopy/d3-victory-comparison
  2. $ cd d3-victory-comparison && npm install
  3. $ node_modules/.bin/webpack-dev-server
ERROR in ./~/victory-bar/lib/components/victory-bar.js
Module not found: Error: Cannot resolve module 'lodash/object/pick' in /Users/per/dev/formidable/victory/d3-victory-comparison/node_modules/victory-bar/lib/components
 @ ./~/victory-bar/lib/components/victory-bar.js 63:24-53

We find that lodash version 4.0.0 is installed:

$ cat node_modules/lodash/package.json | grep version
  "version": "4.0.0"

One of the dependencies have a dependency on lodash 4-5:

find . -name package.json | xargs grep "\"lodash\":"`
./node_modules/argparse/package.json:    "lodash": ">= 4.0.0 < 5.0.0",

The argparse lodash dep ends up overriding the archetype lodash (which is set to ^3.10.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Development

No branches or pull requests

1 participant