Fixed typescript props bug and added typescript compile to lint process

FormidableLabs · Feb 6, 2020 · b916476 · b916476
1 parent b1ec35a
commit b916476
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/package-scripts.js b/package-scripts.js
@@ -39,12 +39,14 @@ module.exports = {
       stories: "eslint --color stories",
       storybook: "eslint --color --no-ignore .storybook/config.js",
       test: "eslint --color test",
+      ts: "tsc --project tsconfig.json --noEmit",
       default: npsUtils.series.nps(
         "lint.test",
         "lint.stories",
         "lint.storybook",
         "lint.demo",
-        "lint.src"
+        "lint.src",
+        "lint.ts"
       )
     },
     format: {

diff --git a/packages/victory-chart/src/index.d.ts b/packages/victory-chart/src/index.d.ts
@@ -11,6 +11,7 @@
 
 import * as React from "react";
 import {
+  CategoryPropType,
   EventPropTypeInterface,
   DomainPropType,
   DomainPaddingPropType,
@@ -20,6 +21,7 @@ import {
 } from "victory-core";
 
 export interface VictoryChartProps extends VictoryCommonProps {
+  categories?: CategoryPropType;
   domain?: DomainPropType;
   domainPadding?: DomainPaddingPropType;
   events?: EventPropTypeInterface<string, StringOrNumberOrCallback>[];

diff --git a/packages/victory-core/src/index.d.ts b/packages/victory-core/src/index.d.ts
@@ -487,7 +487,6 @@ export type ColorScalePropType =
 
 export interface VictoryCommonProps {
   animate?: boolean | AnimatePropTypeInterface;
-  categories?: string | { x?: string[]; y?: string[] };
   name?: string;
   height?: number;
   horizontal?: boolean;

diff --git a/tsconfig.json b/tsconfig.json
@@ -22,8 +22,8 @@
     }
   },
   "include": [
-    "**/*.ts",
-    "**/*.tsx"
+    "**/src/*",
+    "demo/ts/*"
   ],
   "exclude": [
       "node_modules",