Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Export helper methods as named exports #168

Merged
merged 7 commits into from
Feb 19, 2018

Conversation

aronstrandberg
Copy link
Contributor

Issue: #650

  • Export all methods individually as named exports, instead of export all helpers as a default export in the form of an object
  • Reorder the method definitions to counter eslint's no-use-before-define errors. This makes the diff look mighty weird, so it might be easier to look at the individual commits' diff

I'll be happy to make any changes you find necessary.

@aronstrandberg
Copy link
Contributor Author

I don't know if you can squash the commits when merging – let me know otherwise and I can push a squashed version here.

@boygirl
Copy link
Contributor

boygirl commented Feb 16, 2018

@aronstrandberg thanks for this improvement. Actually, though, the I believe the only method that needs to be exported is getBaseProps. I will merge this work after that small change.

@aronstrandberg
Copy link
Contributor Author

@boygirl thanks! I pushed two commits that should fix this

@boygirl
Copy link
Contributor

boygirl commented Feb 19, 2018

Looks good! thanks!

@boygirl boygirl merged commit 41036d9 into FormidableLabs:master Feb 19, 2018
@aronstrandberg aronstrandberg deleted the helpers-named-exports branch February 20, 2018 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants