-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: render custom x/y axis nodes #470
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 8765258 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bigger question, thoughts on updating formatYLabel
to allow users to return Skia components instead of limiting it only a string
? This would allow users to handle drawing images, but would also allow them to return custom text components (such as paragraph
to support line breaks.
allows users to pass in a `tickImages` node to either x or y axis which will display an image instead of a tick value.
3a064c4
to
8765258
Compare
Description
allows users to pass in a
renderXLabel
orrenderYLabel
prop to either x or y axis which allows them to render anything they want.Fixes #309
Type of Change
Checklist: (Feel free to delete this section upon completion)
yarn run check:code
and all checks pass