Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render custom x/y axis nodes #470

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: render custom x/y axis nodes #470

wants to merge 10 commits into from

Conversation

zibs
Copy link
Contributor

@zibs zibs commented Jan 9, 2025

Description

allows users to pass in a renderXLabel or renderYLabel prop to either x or y axis which allows them to render anything they want.

Screenshot 2025-01-09 at 8 35 36 AM Screenshot 2025-01-09 at 8 35 30 AM

Fixes #309

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 8765258

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:07pm

Copy link
Member

@keithluchtel keithluchtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bigger question, thoughts on updating formatYLabel to allow users to return Skia components instead of limiting it only a string? This would allow users to handle drawing images, but would also allow them to return custom text components (such as paragraph to support line breaks.

lib/src/cartesian/components/YAxis.tsx Outdated Show resolved Hide resolved
@zibs
Copy link
Contributor Author

zibs commented Jan 9, 2025

Take a look at the last PR and see if this is along the lines of what we might want. It allows for Text/Paragraph/Image etc.

Screenshot 2025-01-09 at 12 08 31 PM

lib/src/types.ts Outdated Show resolved Hide resolved
lib/src/cartesian/components/AxisImage.tsx Outdated Show resolved Hide resolved
example/app/axis-images.tsx Outdated Show resolved Hide resolved
@zibs zibs changed the title feat: add axis images feat: render custom x/y axis nodes Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we add image or icon on y-axis
4 participants