This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Improvement/events perf #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbolin
approved these changes
Apr 17, 2018
| @@ -92,6 +92,9 @@ export default { | |||
|
|
|||
| // returns all eventKeys to modify for a targeted childName | |||
| const getKeys = (childName) => { | |||
| if (target === "parent") { | |||
| return "parent"; | |||
| } | |||
| if (eventReturn.eventKey === "all") { | |||
| return baseProps[childName] ? | |||
| without(Object.keys(baseProps[childName]), "parent") : | |||
There was a problem hiding this comment.
NIT: we're using both lodash.keys and Object.keys in this file. idk which is faster, but we might want to go with just one
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrisbolin this PR prevents a bunch of unnecessary state mutation and filters all falsey mutations out of shared state. This is not a breaking change.