Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Add support for top/bottom/left/right gutter. #320

Merged
merged 2 commits into from
Dec 4, 2017

Conversation

exogen
Copy link
Contributor

@exogen exogen commented Dec 2, 2017

@boygirl I think this does the trick!

This is an alternative to #319 that replaces rowGutter with gutter accepting top, bottom, left, and right properties.

Alternatively, we could keep rowGutter and have gutter={ left, right } + rowGutter={ top, bottom } – thoughts?

Appears to work like a charm, here's gutter={{ left: 20, right: 50, top: 5, bottom: 8 }}:

screen shot 2017-12-01 at 4 45 41 pm

Fixes FormidableLabs/victory#862.

@boygirl
Copy link
Contributor

boygirl commented Dec 4, 2017

@exogen sorry for the delay. I prefer gutter={ left, right } + rowGutter={ top, bottom } with support for single numbers or objects to avoid the breaking change.

@exogen exogen force-pushed the feat/gutter-top-bottom-left-right branch from 519966a to efa8d66 Compare December 4, 2017 23:16
@exogen
Copy link
Contributor Author

exogen commented Dec 4, 2017

@boygirl Should be ready!

@boygirl
Copy link
Contributor

boygirl commented Dec 4, 2017

Thanks!

@boygirl boygirl merged commit aba0ff5 into master Dec 4, 2017
@boygirl boygirl deleted the feat/gutter-top-bottom-left-right branch December 4, 2017 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants