Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Render Charts in div #299

Merged
merged 8 commits into from
Sep 25, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
foreignObject experiment
  • Loading branch information
boygirl committed Sep 18, 2017
commit ef82c062fb1ac892b59d58a256d134d418996dea
15 changes: 13 additions & 2 deletions src/victory-tooltip/victory-tooltip.js
Original file line number Diff line number Diff line change
Expand Up @@ -354,16 +354,27 @@ export default class VictoryTooltip extends React.Component {
return renderInPortal ? <VictoryPortal>{null}</VictoryPortal> : null;
}
const calculatedValues = this.getCalculatedValues(evaluatedProps);
const flyoutProps = this.getFlyoutProps(evaluatedProps, calculatedValues);
const children = [
React.cloneElement(flyoutComponent, this.getFlyoutProps(evaluatedProps, calculatedValues)),
React.cloneElement(flyoutComponent, flyoutProps),
React.cloneElement(labelComponent, this.getLabelProps(evaluatedProps, calculatedValues))
];
const tooltip = React.cloneElement(
groupComponent,
{ role: "presentation", transform: calculatedValues.transform },
children
);
return renderInPortal ? <VictoryPortal>{tooltip}</VictoryPortal> : tooltip;
const zIndexTooltips = (
<foreignObject>
<div style={{ position: "relative", zIndex: 100 }}>
<svg overflow="visible">
{tooltip}
</svg>
</div>
</foreignObject>
);
// return renderInPortal ? <VictoryPortal>{tooltip}</VictoryPortal> : tooltip;
return renderInPortal ? <VictoryPortal>{zIndexTooltips}</VictoryPortal> : zIndexTooltips;
}

render() {
Expand Down