Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Victory stack issues #551

Merged
merged 6 commits into from
Jan 14, 2018
Merged

Victory stack issues #551

merged 6 commits into from
Jan 14, 2018

Conversation

stefvhuynh
Copy link
Contributor

Resolves FormidableLabs/victory#809, FormidableLabs/victory#805, and FormidableLabs/victory#615

  • Fixes the behavior of explicit y = null values
  • Adds a prop fillInMissingData which is defaulted to true
  • If any dataset is missing an x value represented in any other dataset, a value for that x will be provided with y = 0
  • If fillInMissingData = false, then that value will be y = null

@boygirl
Copy link
Contributor

boygirl commented Jan 14, 2018

@stefvhuynh works great for me. Merging

@boygirl boygirl merged commit 994eca2 into master Jan 14, 2018
@boygirl boygirl deleted the victory-stack-issues branch January 14, 2018 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants