This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on FormidableLabs/victory-core#196
This PR Adds
VictoryVoronoiContainer
for hover events (tooltips).VictoryVoronoiContainer
has several benefits overVictoryVoronoi
andVictoryVoronoiTooltip
dimension="x"
creates vertical hover areas for every unique x value in all child dataThis PR also deprecates
label
in favor oflabels
inVictoryLine
andVictoryArea
, allowing individual data labels for these components like in other Victory components. This will be a breaking change for anyone using thelabel
prop in VictoryLine or VictoryArea. Series labels will need to be configured manuallyThis PR also changes how null values are handled in VictoryArea, and groups all line and area segments (i.e. split by null values) into the same eventKey, so that they operate as a single line for the purposes of events.