Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Feature/voronoi container #432

Merged
merged 28 commits into from
Feb 25, 2017
Merged

Feature/voronoi container #432

merged 28 commits into from
Feb 25, 2017

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Feb 7, 2017

depends on FormidableLabs/victory-core#196

This PR Adds VictoryVoronoiContainer for hover events (tooltips). VictoryVoronoiContainer has several benefits over VictoryVoronoi and VictoryVoronoiTooltip

  • Supports multi-dataset voronoi
  • Much better performance (voronoi polygons are not actually rendered, so the number of nodes rendered is dramatically lower)
  • Supports multi-data tooltips
  • Supports rectangular selections with a dimension prop i.e. dimension="x" creates vertical hover areas for every unique x value in all child data

This PR also deprecates label in favor of labels in VictoryLine and VictoryArea, allowing individual data labels for these components like in other Victory components. This will be a breaking change for anyone using the label prop in VictoryLine or VictoryArea. Series labels will need to be configured manually

This PR also changes how null values are handled in VictoryArea, and groups all line and area segments (i.e. split by null values) into the same eventKey, so that they operate as a single line for the purposes of events.

@boygirl boygirl changed the title [WIP] Feature/voronoi container Feature/voronoi container Feb 23, 2017
@boygirl boygirl merged commit e144a79 into master Feb 25, 2017
@boygirl boygirl deleted the feature/voronoi-container branch February 25, 2017 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant