Clean domain method #317
Clean domain method #317
Conversation
| return this.cleanDomain(this.padDomain(domain, props, axis), props); | ||
| }, | ||
|
|
||
| cleanDomain(domain, props) { |
There was a problem hiding this comment.
I think you can simplify this method if you add an axis argument
|
cc/ @ebrillhart I figured it out! We needed to replace the baseline (y0) with a very small number in these charts prior to scaling them. |
|
@boygirl yay!! what else needs to be done on this? |
|
@ebrillhart the y-axis labels (and possibly domain) on log scales are wrong for bar and area. You can address that in this branch or open another issue. Your pick. |
|
@ebrillhart actually pause. I think I messed something up with horizontal bars. One moment |
|
Okay, fixed. Sorry about that |
|
@boygirl no prob! was the weird tick label and domain thing the aspect that we determined was a d3 issue? what would your suggestion be for a starting approach to that? |
|
@ebrillhart please check on what's getting passed to VictoryAxis in these cases. If it's getting the domain and scale that you expect then I think it's a d3 issue with tick formatting, and we will address it in it separate issue. |
this should help fix https://github.com/FormidableLabs/victory-chart/issues/146, #306, #299
right now this works great for everything except bar scales, which is weird because it's working with area and that's the same domain method. might be something to look at today in pairing @boygirl