Upgrade docs site to react-static v7 #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kale-stew
force-pushed
the
task/update-react-static
branch
3 times, most recently
from
6598327 to
3751dde
Compare
added 20 commits
April 12, 2020 21:36
kale-stew
force-pushed
the
task/update-react-static
branch
from
1c777ec to
b272c71
Compare
kale-stew
force-pushed
the
task/update-react-static
branch
from
628eb27 to
6b6799c
Compare
kale-stew
commented
Apr 14, 2020
| - [Heroku](https://devcenter.heroku.com/articles/git#deploying-code) | ||
| - [Zeit](https://zeit.co/docs/v2/platform/deployments) | ||
| - [Surge](https://surge.sh/help/deploying-continuously-using-git-hooks) | ||
| 1. If you are integrating this lib yourself, take your build and follow the linked instructions from any of (but not limited to) the following providers: [Heroku](https://devcenter.heroku.com/articles/git#deploying-code), [Zeit](https://zeit.co/docs/v2/platform/deployments), or [Surge](https://surge.sh/help/deploying-continuously-using-git-hooks). |
There was a problem hiding this comment.
The formatting for this list of links was weird, so I opted to keep the links inline instead.
kale-stew
commented
Apr 14, 2020
| order: 1 | ||
| --- | ||
|
|
||
| <a name="basic-concepts"></a> |
There was a problem hiding this comment.
We found these <a> tags were to blame for the persistent 404.
kale-stew
commented
Apr 14, 2020
|
|
||
| ## Space | ||
|
|
||
| **Space** props used by [`Box`](/docs/api-reference#box), [`FlexBox`](/docs/api-reference#flex-box), [`Grid`](/docs/api-reference#grid), [`CodeSpan`](/docs/api-reference#code-span), [`Text`](/docs/api-reference#text), [`Link`](/docs/api-reference#link), [`Heading`](/docs/api-reference#heading), [`Quote`](/docs/api-reference#quote), [`Table`](/docs/api-reference#table), [`TableHeader`](/docs/api-reference#table-header), [`TableBody`](/docs/api-reference#table-body), [`TableRow`](/docs/api-reference#table-row), [`TableCell`](/docs/api-reference#table-cell), [`UnorderedList`](/docs/api-reference#unordered-list), [`OrderedList`](/docs/api-reference#ordered-list), and [`ListItem`](/docs/api-reference#list-item). |
There was a problem hiding this comment.
These links are known not to work locally for the time being. See #877 for more thorough tracking of this issue.
carloskelly13
approved these changes
Apr 15, 2020
kale-stew
pushed a commit
that referenced
this pull request
Apr 17, 2020
* Upgrade docs site to react-static v7 (#873) * update packages * consume global styles, add Loading state * import Link from react-router-dom instead of react-static * Improve hot reloading * Move colors into a theme, update global-style accordingly * Rename markdown.js * svg cleanup - delete unused, add new * Add 404 content * gut static-config helpers in favor of react-static-plugin-md-pages, update deps * add SidebarList (sub-navigation) to the Article view * Theme improvements * Remove anchor tags that were breaking the docs * Style improvements * Initalize docs/ route * Use formidable-oss-badges instead of local svgs * Downgrade react-static-plugin-md-pages for CI 🤞 * Add a blank index w/ content * Use local paths in docs content * Add Featured Badges * Add urql and runpkg * Use formidable-oss-badges instead of local svg * Make sure format script reaches markdown content * Get rid of word-break overflow * Improve doc table formatting * Use svg info from formidable-oss-landers * Move public + manifest data to top-level public dirs * Remove unused & hard to find assets, update preview pres data * Bug/broken links (#881) Co-authored-by: boygirl <lauren.eastridge@formidable.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates react and react-static to the latest and greatest, which will both improve our dev experience and bring our docs into 2020.
Fixes #838
Remaining work to be done before this PR is g2g:
/docsso it initializes to/basic-conceptsinstead of 404-ing