Skip to content

BUG: Prism production build failure + misc. #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2020
Merged

BUG: Prism production build failure + misc. #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afdb9dc
various cleanup
ryan-roemer Mar 6, 2020
1185e86
Temp enable travis.
ryan-roemer Mar 6, 2020
fdc6d20
Disable task/rewrite CI
ryan-roemer Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/dist-prod/open-source/spectacle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
../../dist
4 changes: 2 additions & 2 deletions docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
"check-ci": "yarn run lint",
"clean": "rimraf dist",
"format": "yarn run lint --fix && yarn run prettier-all",
"lint": "eslint 'src/**/*.js' 'static-config-*/*.js' 'src/**/*.js' 'static.config.js'",
"prettier-all": "prettier --write '{src,static-config-helpers,static-config-parts,static.config,scripts,lib}/**/*.{js,jsx}'",
"lint": "eslint '*.js' src scripts 'static-config-*/*.js'",
"prettier-all": "prettier --write '{src,static-config-helpers,static-config-parts,static.config,scripts}/**/*.{js,jsx}'",
"preversion": "yarn run lint && yarn run build",
"prod:build": "react-static build",
"prod:deploy": "node scripts/deploy/aws.js",
Expand Down
15 changes: 15 additions & 0 deletions docs/static-config-parts/static-webpack-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,22 @@
// THAT ENHANCES THE BASE REACT-STATIC WEBPACK CONFIG.

const staticWebpackConfig = (config, { defaultLoaders }) => {
// BUG/HACK: Disable CSS minification to avoid module build error:
// "Module build failed: BrowserslistError: Unknown browser query `dead`"
// https://github.com/FormidableLabs/spectacle/issues/857
defaultLoaders.cssLoader.loader.forEach(({ loader, options }) => {
if (loader === 'css-loader') {
options.minimize = false;
}
});

// Add development file info.
config.output.pathinfo =
config.output.pathinfo || process.env.REACT_STATIC_ENV === 'development';
// No source maps.
config.devtool = false;

// Enhance rules.
config.module.rules = [
{
oneOf: [
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"check": "yarn lint && yarn prettier-check && yarn test",
"check-ci": "yarn run check",
"format": "yarn run lint-fix && yarn run prettier-fix",
"lint": "eslint --ignore-path .gitignore .",
"lint": "eslint '*.js' 'examples/**/*.js' src scripts 'docs/*.js' docs/src docs/scripts 'docs/static-config-*/*.js'",
"lint-fix": "yarn lint --fix",
"prettier": "prettier \"**/*.{js,json,ts,css,md}\"",
"prettier-check": "yarn prettier --check",
Expand Down
10 changes: 9 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6309,7 +6309,7 @@ react-is@^16.12.0, react-is@^16.8.4:
resolved "https://registry.yarnpkg.com/react-is/-/react-is-16.12.0.tgz#2cc0fe0fba742d97fd527c42a13bec4eeb06241c"
integrity sha512-rPCkf/mWBtKc97aLL9/txD8DZdemK0vkA3JMLShjlJB3Pj3s+lpf1KaBzMfQrAmhMQB0n1cU/SUGgKKBCe837Q==

react-is@^16.6.0, react-is@^16.8.1, react-is@^16.8.6, react-is@^16.9.0:
react-is@^16.6.0, react-is@^16.8.1, react-is@^16.9.0:
version "16.9.0"
resolved "https://registry.yarnpkg.com/react-is/-/react-is-16.9.0.tgz#21ca9561399aad0ff1a7701c01683e8ca981edcb"
integrity sha512-tJBzzzIgnnRfEm046qRcURvwQnZVXmuCbscxUO5RWrGTXpon2d4c8mI0D8WE6ydVIm29JiLB6+RslkIvym9Rjw==
Expand Down Expand Up @@ -6733,6 +6733,14 @@ sax@^1.2.4:
resolved "https://registry.yarnpkg.com/sax/-/sax-1.2.4.tgz#2816234e2378bddc4e5354fab5caa895df7100d9"
integrity sha512-NqVDv9TpANUjFm0N8uM5GxL36UgKi9/atZw+x7YFnQ8ckwFGKrl4xX4yWtrey3UJm5nP1kUbnYgLopqWNSRhWw==

scheduler@^0.15.0:
version "0.15.0"
resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.15.0.tgz#6bfcf80ff850b280fed4aeecc6513bc0b4f17f8e"
integrity sha512-xAefmSfN6jqAa7Kuq7LIJY0bwAPG3xlCj0HMEBQk1lxYiDKZscY2xJ5U/61ZTrYbmNQbXa+gc7czPkVo11tnCg==
dependencies:
loose-envify "^1.1.0"
object-assign "^4.1.1"

scheduler@^0.18.0:
version "0.18.0"
resolved "https://registry.yarnpkg.com/scheduler/-/scheduler-0.18.0.tgz#5901ad6659bc1d8f3fdaf36eb7a67b0d6746b1c4"
Expand Down