Skip to content

Support Notes for MD parsing #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2019
Merged

Support Notes for MD parsing #762

merged 2 commits into from
Nov 2, 2019

Conversation

@carloskelly13
Copy link
Contributor

Support Notes for the Markdown Slides Component

<Markdown containsSlides>
      {`
        ### First MD generated Slide
        Notes: These are notes
        ---
        ### Second MD Generated Slide
        Notes: These are more notes
      `}
</Markdown>

Screen Shot 2019-11-02 at 12 36 19 PM

Screen Shot 2019-11-02 at 12 36 25 PM

carloskelly13
carloskelly13 commented Nov 2, 2019
View reviewed changes
src/utils/notes.js
return content.substring(0, indexOfNotes);
}
return content;
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These functions are from the spectacle-cli package. Next update to the CLI will use these instead of having them in that repo.

rgerstenberger
rgerstenberger reviewed Nov 2, 2019
View reviewed changes
rgerstenberger
rgerstenberger approved these changes Nov 2, 2019
View reviewed changes
Copy link

@rgerstenberger rgerstenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carloskelly13 carloskelly13 merged commit 62fdbff into task/rewrite Nov 2, 2019
@carloskelly13 carloskelly13 deleted the rewrite/md-notes branch November 2, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rgerstenberger rgerstenberger rgerstenberger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carloskelly13 @rgerstenberger