keyboardControls #760
Merged
keyboardControls #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Extracted fullscreen hook from fullscreen button. 1. Added dispatch ToggleMode 1. Added key bindings for overviewMode, presenterMode and fullscreen modes.
|
FWIW I do not have a windows computer to test on so I assume these work. |
kiraarghy
commented
Nov 1, 2019
src/hooks/use-keyboard-controls.js
Outdated
| e.preventDefault(); | ||
| } | ||
| } | ||
| if (!!e.altKey) { |
There was a problem hiding this comment.
I guess there may be an argument that this hook is doing too much.
I like that all the logic is co-located but happy for feedback.
kiraarghy
requested review from
SunburtReynolds,
alex-saunders,
carloskelly13,
kale-stew and
ryan-roemer
carloskelly13
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch provides feature parity with existing spectacle for the keybindings for setting specific modes.
Alt + P -> Presenter mode.
Alt + O -> Overview mode.
Alt + F -> Fullscreen mode.
https://github.com/FormidableLabs/spectacle#controls