Skip to content

Avoid in/out transitions in export and presenter modes #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Avoid in/out transitions in export and presenter modes #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/__snapshots__/manager.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,8 @@ exports[`<Manager /> should render the export configuration when specified. 1`]
slideIndex={0}
transition={Array []}
transitionDuration={0}
transitionIn={Array []}
transitionOut={Array []}
>
<div>
Slide Content
Expand All @@ -401,6 +403,8 @@ exports[`<Manager /> should render the export configuration when specified. 1`]
slideIndex={1}
transition={Array []}
transitionDuration={0}
transitionIn={Array []}
transitionOut={Array []}
>
<div>
Slide Content
Expand Down
12 changes: 12 additions & 0 deletions src/components/__snapshots__/presenter.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ exports[`<Presenter /> should render correctly 1`] = `
slideIndex={1}
transition={Array []}
transitionDuration={0}
transitionIn={Array []}
transitionOut={Array []}
>
<div>
Slide Content
Expand Down Expand Up @@ -134,6 +136,8 @@ exports[`<Presenter /> should render correctly 1`] = `
slideIndex={2}
transition={Array []}
transitionDuration={0}
transitionIn={Array []}
transitionOut={Array []}
>
<div>
Slide Content
Expand Down Expand Up @@ -288,6 +292,8 @@ exports[`<Presenter /> should render timer when set in params. 1`] = `
slideIndex={1}
transition={Array []}
transitionDuration={0}
transitionIn={Array []}
transitionOut={Array []}
>
<div>
Slide Content
Expand Down Expand Up @@ -315,6 +321,8 @@ exports[`<Presenter /> should render timer when set in params. 1`] = `
slideIndex={2}
transition={Array []}
transitionDuration={0}
transitionIn={Array []}
transitionOut={Array []}
>
<div>
Slide Content
Expand Down Expand Up @@ -454,6 +462,8 @@ exports[`<Presenter /> should render with notes when slides have them. 1`] = `
slideIndex={1}
transition={Array []}
transitionDuration={0}
transitionIn={Array []}
transitionOut={Array []}
>
<div>
Slide Content
Expand Down Expand Up @@ -481,6 +491,8 @@ exports[`<Presenter /> should render with notes when slides have them. 1`] = `
slideIndex={2}
transition={Array []}
transitionDuration={0}
transitionIn={Array []}
transitionOut={Array []}
>
<div>
Slide Content
Expand Down
2 changes: 2 additions & 0 deletions src/components/export.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ export default class Export extends Component {
export: this.props.route.params.indexOf('export') !== -1,
print: this.props.route.params.indexOf('print') !== -1,
transition: [],
transitionIn: [],
transitionOut: [],
transitionDuration: 0
});
});
Expand Down
4 changes: 4 additions & 0 deletions src/components/presenter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ export default class Presenter extends Component {
slideIndex,
lastSlideIndex,
transition: [],
transitionIn: [],
transitionOut: [],
transitionDuration: 0,
presenterStyle,
});
Expand All @@ -83,6 +85,8 @@ export default class Presenter extends Component {
slideIndex: slideIndex + 1,
lastSlideIndex,
transition: [],
transitionIn: [],
transitionOut: [],
transitionDuration: 0,
presenterStyle,
appearOff: true,
Expand Down