Remove all CSS files #399
Merged
Remove all CSS files #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Delete prism.{dark,light}.css
- Move prism themes into a css`` block
- Add `prism` to theme
- Use prism themes in CodePane and ComponentPlayground
kenwheeler
approved these changes
Nov 6, 2017
- Add theme.components.syntax for all Editor components, like the one in ComponentPlayground and CodePane - Removed prism.base.js since those are now inside the syntax styles - Added specificity override to Editor components to allow for external prism CSS theme - Use tertiary font-family in all syntax components
carloskelly13
approved these changes
Nov 6, 2017
ryan-roemer
reviewed
Nov 7, 2017
src/themes/default/screen.js
Outdated
| tabSize: 2, | ||
| hyphens: 'none', | ||
| whiteSpace: 'pre-wrap', | ||
|
|
There was a problem hiding this comment.
Oh, sorry, I'm used to separate some CSS properties from each other. Will get rid of it 😄
ryan-roemer
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #291
src/themes/defaultinto a newprismproperty containinglightanddarkindex.cssintotheme.globaland removeindex.cssIt seems that
normalize.cssis not required anymore btw. The example presentation seems 100% ok without it, as far as I can tell.Edit: The commit 6c678b1 allows a user to just include a prism css file like so to override the default two prism themes:
This takes a higher precedence than emotion, but the base file does include some styles that are more important, which have been assigned a higher specificity:
spectacle/src/themes/default/prism.base.js
Lines 23 to 28 in 6c678b1
This means that those can still be overridden using
!important.