-
Couldn't load subscription status.
- Fork 699
Add fullscreen button to ComponentPlayground #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
308e7a2 to
6ca191b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🎉
|
Quick note after testing Safari w/ @carlospaelinck: this doesn’t take into account yet that spectacle might already be in full screen mode Edit: It turns out that I can't replace the fullscreen element for Safari by closing and reopening as browsers only accept a fullscreen request as part of a user interaction. |
5e80664 to
b21eea5
Compare
|
@philpl I implemented a custom "editor" component and also integrated a fullscreen mode by putting the content into a wrapper with absolute positioning and a z-index. This works even if spectacle is already in fullscreen mode. |
|
@evertmi the way to go if we need more fullscreen-able components is definitely an abstraction, maybe even a portal component, to support Safari. For now this should definitely be sufficient for the current use case |
fe5adfc to
d1d2af5
Compare
ed3e267 to
b2bcb75
Compare
Fix #316
Depends on #391
Adds a fullscreen button to the
ComponentPlaygroundthat uses the Fullscreen API.