Skip to content

Conversation

@kitten
Copy link
Contributor

@kitten kitten commented Nov 1, 2017

Fix #316
Depends on #391

Adds a fullscreen button to the ComponentPlayground that uses the Fullscreen API.

@kitten kitten force-pushed the feature/fullscreen-playground branch from 308e7a2 to 6ca191b Compare November 1, 2017 19:36
Copy link
Contributor

@carloskelly13 carloskelly13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@kitten
Copy link
Contributor Author

kitten commented Nov 1, 2017

Quick note after testing Safari w/ @carlospaelinck: this doesn’t take into account yet that spectacle might already be in full screen mode

Edit: It turns out that I can't replace the fullscreen element for Safari by closing and reopening as browsers only accept a fullscreen request as part of a user interaction.

@kitten kitten force-pushed the feature/fullscreen-playground branch from 5e80664 to b21eea5 Compare November 2, 2017 15:41
@kitten kitten changed the title Feature/fullscreen playground Add fullscreen button to ComponentPlayground Nov 2, 2017
@ebertmi
Copy link

ebertmi commented Nov 3, 2017

@philpl I implemented a custom "editor" component and also integrated a fullscreen mode by putting the content into a wrapper with absolute positioning and a z-index. This works even if spectacle is already in fullscreen mode.

@kitten
Copy link
Contributor Author

kitten commented Nov 3, 2017

@evertmi the way to go if we need more fullscreen-able components is definitely an abstraction, maybe even a portal component, to support Safari.

For now this should definitely be sufficient for the current use case

@kitten kitten force-pushed the feature/fullscreen-playground branch from fe5adfc to d1d2af5 Compare November 3, 2017 14:48
@kitten kitten force-pushed the feature/fullscreen-playground branch from ed3e267 to b2bcb75 Compare November 3, 2017 15:01
@kitten kitten merged commit 4de1b2d into master Nov 3, 2017
@kitten kitten deleted the feature/fullscreen-playground branch November 3, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants