Added out-of-order slide navigation. #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carloskelly13
commented
Nov 1, 2017
| this._detachEvents(); | ||
| } | ||
|
|
||
| viewedIndexes = new Set(); |
There was a problem hiding this comment.
viewedIndexes is just a property on the class because we don’t need to re-render the Manager when it changes. Therefore having it in state isn't necessary.
carloskelly13
commented
Nov 1, 2017
| return this._nextUnviewedIndex(); | ||
| } | ||
| return goTo - 1; | ||
| }; |
There was a problem hiding this comment.
The goToIndex() func prevents the infinite viewing loop. If we’ve already seen that out-of-order slide, let’s go to the next unviewed index.
kenwheeler
approved these changes
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goToprop on<Slide />I used a
Setto track viewed indexes to ensure slides are only shown once. Indexes are removed when we navigate backwards so slides can be re-shown. A viewed index ordered set is necessary to prevent an infinite loop. For example, if Slide 2 directs to 4, and Slide 4 directs to 3, when we go forward from 3, we want to go to 5, otherwise we will be stuck in a loop of 4 to 2, 2 to 3 to 4.Addresses #375