Replace component-playground with react-live #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update README - Replace playground.css with (emotion) styled react-live components - Replace codemirror themes with DuoTone prism themes modified for react-live - Fix up playground default code - Fix up playground tests and snapshots - Remove codemirror and playground CSS
|
Dude. Amazing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-live
As a next step we could get rid of the CDN prism bundle and instead use a disabled React Live Editor. This might need some modifications and we'd have to pull in more parts of Prism, but react-live's usage of prism would allow this: https://github.com/FormidableLabs/react-live/blob/master/src/utils/prism.js